Pin pandas yet again 🐼 test_icon fails again with pandas=2.2.2
#2394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2394 +/- ##
=======================================
Coverage 94.28% 94.28%
=======================================
Files 246 246
Lines 13511 13511
=======================================
Hits 12739 12739
Misses 772 772 ☔ View full report in Codecov by Sentry. |
schlunma
approved these changes
Apr 14, 2024
Contributor
schlunma
left a comment
schlunma
left a comment
There was a problem hiding this comment.
Thanks V, just one tiny comment!
We should maybe think about fixing this in the code, it's really annoying to pin pandas every month..
From the issue description here it looks like scalar time points are correctly rounded, i.e., the following should work:
[d.round('s') for d in datetime_array]
Co-authored-by: Manuel Schlund <[email protected]>
Contributor
Author
|
thanks a lot, Manu! I too agree with fixing the test rather than pinning the ninja bears, but I didn't have the will to look at it closer - good call you did, you mind opening a PR with the fix pls, bud? 🍺 In the meantime this will do 🐼 |
chrisbillowsMO
changed the title
test_icon fails again with pandas=2.2.2test_icon fails again with pandas=2.2.2
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tests are failing with the same issue we had in the past, described by @schlunma in #2305 and with an original bug report in pandas at pandas-dev/pandas#57002 - they just switched the milestone for that for 2.2.3 apparently!
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: