Allow cubes as input for bias preprocessor
#2183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2183 +/- ##
==========================================
+ Coverage 93.72% 93.74% +0.01%
==========================================
Files 238 238
Lines 13125 13153 +28
==========================================
+ Hits 12302 12330 +28
Misses 823 823 ☔ View full report in Codecov by Sentry. |
Contributor
|
I'll have a review done tomorrow, bud |
valeriupredoi
requested changes
Jan 18, 2024
Contributor
valeriupredoi
left a comment
valeriupredoi
left a comment
There was a problem hiding this comment.
looking very good, and cheers, Manu! The two reasons why I'm not approving straightaway are that error that I think needs be a bit more explicit, and (for the life of me) I can't see how those two integration tests differ 🍺
valeriupredoi
approved these changes
Jan 23, 2024
Contributor
valeriupredoi
left a comment
valeriupredoi
left a comment
There was a problem hiding this comment.
many thanks for addressing the review points, bud 🍺
Contributor
Author
|
Thanks for the review V! Merging this now since I need it to continue with #2299. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows using cubes as input for the bias preprocessor, which drastically increases its usability outside of recipes. Additionally, I added a check if the
bias_typeargument is valid that is executed much earlier before processing datasets.Closes #2082
Link to documentation: https://esmvaltool--2183.org.readthedocs.build/projects/ESMValCore/en/2183/recipe/preprocessor.html#bias
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: