Skip to content

Conversation

@bouweandela
Copy link
Member

@bouweandela bouweandela commented Jan 3, 2023

Description

There is an accidental space character in the name of the file esmvalcore/cmor/_fixes/cordex/__init__ .py. This pull request renames the file to correct the issue.


Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@bouweandela bouweandela requested a review from sloosvel January 3, 2023 14:46
@bouweandela bouweandela added the bug Something isn't working label Jan 3, 2023
@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Merging #1883 (8ffcb9e) into main (31328ed) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1883   +/-   ##
=======================================
  Coverage   91.65%   91.65%           
=======================================
  Files         232      232           
  Lines       11555    11555           
=======================================
  Hits        10591    10591           
  Misses        964      964           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bouweandela bouweandela marked this pull request as ready for review January 3, 2023 14:53
@bouweandela bouweandela changed the title Correct a mistake in a filename Remove an extra space from a filename Jan 3, 2023
@bouweandela bouweandela changed the title Remove an extra space from a filename Remove an extra space character from a filename Jan 3, 2023
Copy link
Contributor

@schlunma schlunma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! I think you can merge this yourself, no need for a third person (the change is 100% straightforward) 👍

@bouweandela bouweandela merged commit baeb28d into main Jan 4, 2023
@bouweandela bouweandela deleted the fix-init-filename branch January 4, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants