-
Notifications
You must be signed in to change notification settings - Fork 44
[v2.7.1 bugfix release] Unpin cf-units and port changes from PR 1770 into v2.7.x #1855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## v2.7.x #1855 +/- ##
==========================================
- Coverage 91.02% 91.00% -0.02%
==========================================
Files 207 207
Lines 11216 11216
==========================================
- Hits 10209 10207 -2
- Misses 1007 1009 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
It's a bit surprising that the tests pass without the new netCDF files added in #1770. Do you understand why, since you didn't add them? |
I have seen this in the other PR too (the one with all the features in one basket), and I don't know why that is - let me have a look |
|
Blast! The sample_data test is identical to the tests/unit/preprocessor/_multimodel/test_multimodel.py test, I must have conked up badly, let me figure that out |
|
also @bouweandela note that we are git ignoring all |
|
OK all back to normal and sane changes vs #1770 😥 |
I know, we've had some issues with people accidentally committing huge netcdf files in the past |
I remember 🤣 It's good we have that block |
These are changes (mostly) done in #1770 that will be needed into the release branch for v2.7.1 bugfix release. The only major change is inside the sample data
test_multimodel.pythat contains a number of previous-to-1770 changes.