Set the version number on the development branches to one minor version more than the previous release #1854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bouweandela
changed the title
main branch to one minor version more than the previous release
Codecov Report
@@ Coverage Diff @@
## main #1854 +/- ##
=======================================
Coverage 91.59% 91.59%
=======================================
Files 203 203
Lines 10989 10989
=======================================
Hits 10065 10065
Misses 924 924 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
zklaus
approved these changes
Dec 8, 2022
zklaus
left a comment
zklaus
left a comment
There was a problem hiding this comment.
LGTM. Should also be cherry-picked into the release branch, right?
Contributor
|
cheers @bouweandela - do we have to pin setuptools_scm be with |
valeriupredoi
approved these changes
Dec 8, 2022
Contributor
|
also, if you turn on GA you can directly see the version after the test runs |
Contributor
|
this looks noice 😁 |
8 tasks
Member
Author
|
@ESMValGroup/technical-lead-development-team Could one of you please do a final check and merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This sets the version number on the
mainand feature branches so it starts withv2.8.0.dev(considering that the current release isv2.7.0). To make a release branch for a previous release, call itv2.7.xand the version number will be automatically correct (e.g. something starting withv2.7.1-devif branched of thev2.7.0tag). This approach avoids the need to merge micro releases back into themainbranch just to get the version number right.@ESMValGroup/technical-lead-development-team
See https://pypi.org/project/setuptools-scm/ for the details.
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: