-
Notifications
You must be signed in to change notification settings - Fork 44
Removed unnecessary test that fails with iris 3.4.0 #1846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1846 +/- ##
=======================================
Coverage 91.54% 91.54%
=======================================
Files 203 203
Lines 10945 10945
=======================================
Hits 10020 10020
Misses 925 925 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
The test coverage will be restored when fixing #1802 (but we need an |
bouweandela
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this!
valeriupredoi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks a lot, Manu! 🍺
Description
This PR removes a test that fails after a bugfix that has been introduced with iris 3.4.0 (SciTools/iris#5062). The tests that check that
dtypeis preserved are now located in iris and can be removed from our test suite.Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: