Skip to content

Conversation

@schlunma
Copy link
Contributor

@schlunma schlunma commented Dec 2, 2022

Description

This PR removes a test that fails after a bugfix that has been introduced with iris 3.4.0 (SciTools/iris#5062). The tests that check that dtype is preserved are now located in iris and can be removed from our test suite.

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@schlunma schlunma added iris Related to the Iris package testing labels Dec 2, 2022
@schlunma schlunma added this to the v2.8.0 milestone Dec 2, 2022
@schlunma schlunma self-assigned this Dec 2, 2022
@codecov
Copy link

codecov bot commented Dec 2, 2022

Codecov Report

Merging #1846 (6be241a) into main (5107f12) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1846   +/-   ##
=======================================
  Coverage   91.54%   91.54%           
=======================================
  Files         203      203           
  Lines       10945    10945           
=======================================
  Hits        10020    10020           
  Misses        925      925           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@schlunma
Copy link
Contributor Author

schlunma commented Dec 2, 2022

The test coverage will be restored when fixing #1802 (but we need an iris>=3.4.0 pin for that one).

Copy link
Member

@bouweandela bouweandela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this!

@valeriupredoi valeriupredoi changed the title Removed unnecessary test that fails in iris 3.4.0 Removed unnecessary test that fails with iris 3.4.0 Dec 2, 2022
Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot, Manu! 🍺

@valeriupredoi valeriupredoi merged commit e09eda2 into main Dec 2, 2022
@valeriupredoi valeriupredoi deleted the fix_regrid_test branch December 2, 2022 11:57
bouweandela added a commit that referenced this pull request Dec 8, 2022
…ure from #1846 (#1857)

Co-authored-by: Bouwe Andela <b.andela@esciencecenter.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

iris Related to the Iris package testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants