Fixed issue in irregular regridding regarding scalar coordinates #1845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1845 +/- ##
=======================================
Coverage 91.54% 91.54%
=======================================
Files 203 203
Lines 10945 10945
=======================================
Hits 10020 10020
Misses 925 925
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Contributor
Author
Contributor
|
cheers for this, you three (not an Xmas reference, I promise 🎄 ) - @remi-kazeroni since Lisa approved as well, feel free to merge 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#1811 introduced the addition of scalar coordinate to the output of the irregular regridding. However, by mistake, I read the scalar coordinates from the source representant, not the source cube itself. Since the representant is the result of slicing the source, it potentially contains many (unwanted) scalar coordinates and also leads to the bug described in #1844.
This PR fixes that.
Closes #1844
Link to documentation:
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: