Skip to content

Improve error handling if an esgf index node is offline #1834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zklaus merged 2 commits into from
Nov 29, 2022
Merged

Improve error handling if an esgf index node is offline #1834

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3928b37
Gracefully handle more errors
bouweandela Nov 28, 2022
eb4322a
Add debug log message
bouweandela Nov 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion esmvalcore/esgf/_search.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,12 @@ def _search_index_nodes(facets):
)
FIRST_ONLINE_INDEX_NODE = url
return results
except requests.exceptions.Timeout as error:
except (
requests.exceptions.ConnectionError,
requests.exceptions.HTTPError,
requests.exceptions.Timeout,
) as error:
logger.debug("Unable to connect to %s due to %s", url, error)
errors.append(error)

raise FileNotFoundError("Failed to search ESGF, unable to connect:\n" +
Expand Down