Skip to content

Xfail esgf search tests if they fail with HTTP error from requests #1830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
valeriupredoi wants to merge 4 commits into from
Closed

Xfail esgf search tests if they fail with HTTP error from requests #1830

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e4ac0e8
xfail test if it fails
valeriupredoi Nov 28, 2022
a412808
run ga
valeriupredoi Nov 28, 2022
762d0aa
fix test recipe too
valeriupredoi Nov 28, 2022
2f2bbe3
dont run ga
valeriupredoi Nov 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions tests/integration/esgf/test_search_download.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
from pathlib import Path

import pytest
import requests
import yaml
from pyesgf.search.results import FileResult

Expand Down Expand Up @@ -128,6 +129,7 @@ def test_mock_search(variable, mocker):
]


@pytest.mark.xfail(raises=requests.exceptions.HTTPError, run=True)
def test_real_search():
"""Test a real search for a single file."""
variable = {
Expand Down
2 changes: 2 additions & 0 deletions tests/integration/test_recipe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@

import iris
import pytest
import requests
import yaml
from nested_lookup import get_occurrence_of_value, nested_update
from PIL import Image
Expand Down Expand Up @@ -1054,6 +1055,7 @@ def test_update_timerange_no_files_online(config_user):
esmvalcore._recipe._update_timerange(variable, config_user)


@pytest.mark.xfail(raises=requests.exceptions.HTTPError, run=True)
def test_update_timerange_no_files_offline(config_user):
variable = {
'alias': 'CMIP6',
Expand Down