Fix siconc in KIOST-ESM #1829
Merged
Fix siconc in KIOST-ESM #1829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valeriupredoi
added
cmor
Contributor
|
Failing test is fixed by #1834 |
Member
Author
|
Thanks @schlunma for adding the tests! |
Codecov Report
@@ Coverage Diff @@
## main #1829 +/- ##
=======================================
Coverage 91.56% 91.56%
=======================================
Files 203 203
Lines 10940 10944 +4
=======================================
+ Hits 10017 10021 +4
Misses 923 923
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
remi-kazeroni
approved these changes
Nov 29, 2022
Contributor
remi-kazeroni
left a comment
remi-kazeroni
left a comment
There was a problem hiding this comment.
LGTM! Thanks both 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The KIOST-ESM model (CMIP6) contains in the siconc field NaNs instead of missing_values. This will be fixed here.
Closes #1828
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.