-
Notifications
You must be signed in to change notification settings - Fork 44
Create a session directory with suffix "-1", "-2", etc if it already exists #1818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1818 +/- ##
=======================================
Coverage 91.49% 91.50%
=======================================
Files 202 202
Lines 10908 10918 +10
=======================================
+ Hits 9980 9990 +10
Misses 928 928
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Question to reviewer: is additional documentation needed here? |
|
@schlunma and @valeriupredoi Maybe this is interesting for you since we recently discussed this in #1769. |
schlunma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I have one small comment.
About the doc: I don't think it is necessary to add documentation on this.
schlunma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
|
@ESMValGroup/technical-lead-development-team Could someone please do a final check and merge? |
on it now, bud! |
valeriupredoi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @bouweandela and @schlunma - looking swanky! I'd put a debug message when new output dirs are created but that's just me being a bit verbose 😁
Description
If the output directory already exists the tool would stop. Now it will try several alternatives by adding a suffix
-1,-2,, etc before giving up. This problem occurs when you try to run multiple recipes with the same name in parallel.Closes #1817
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: