Fix failing test due to missing sample data #1797
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1797 +/- ##
=======================================
Coverage 91.51% 91.51%
=======================================
Files 202 202
Lines 10908 10908
=======================================
Hits 9982 9982
Misses 926 926 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Member
Author
|
The coverage change looks very fishy -> fixed in 2f87419 |
This reverts commit 73c34f2.
valeriupredoi
approved these changes
Nov 15, 2022
Contributor
valeriupredoi
left a comment
valeriupredoi
left a comment
There was a problem hiding this comment.
thank you lots for this @bouweandela - I am also gonna merge since I want to fix my branch too - the one with the deps in env and docs settings, that we should get in soon too - awesome work, bud 🍺
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The tests in
tests/sample_data/experimental/test_run_recipe.pyare failing occasionally because the data cannot be found. This pull request changes the tests so they use their own configuration instead of the global tool configuration. With a bit of luck, this might solve the issue.Closes #1793
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: