Skip to content

Conversation

@valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented Nov 14, 2022

Description

Thanks @zklaus for noticing this 🍺


Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@valeriupredoi valeriupredoi added the bug Something isn't working label Nov 14, 2022
@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Merging #1791 (829358b) into main (4527173) will increase coverage by 0.39%.
The diff coverage is 99.60%.

@@            Coverage Diff             @@
##             main    #1791      +/-   ##
==========================================
+ Coverage   91.11%   91.50%   +0.39%     
==========================================
  Files         203      202       -1     
  Lines       10906    10904       -2     
==========================================
+ Hits         9937     9978      +41     
+ Misses        969      926      -43     
Impacted Files Coverage Δ
esmvalcore/config/_diagnostics.py 87.83% <ø> (ø)
esmvalcore/config/_logging.py 97.67% <ø> (ø)
esmvalcore/config/_config.py 98.68% <98.68%> (ø)
esmvalcore/_citation.py 80.99% <100.00%> (ø)
esmvalcore/_config/__init__.py 100.00% <100.00%> (ø)
esmvalcore/_data_finder.py 96.69% <100.00%> (ø)
esmvalcore/_main.py 90.66% <100.00%> (+13.31%) ⬆️
esmvalcore/_recipe.py 95.81% <100.00%> (-0.10%) ⬇️
esmvalcore/_task.py 71.55% <100.00%> (-0.68%) ⬇️
esmvalcore/cmor/table.py 94.49% <100.00%> (+0.20%) ⬆️
... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link

@zklaus zklaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see we are keeping the reverse alphabetical ordering.

@valeriupredoi
Copy link
Contributor Author

agh! @bouweandela how do you shut up cov - the line's complaining about is ye olde, and saw that in your PR that just got merged too, but thought it'd keep quiet after merge

@valeriupredoi
Copy link
Contributor Author

I see we are keeping the reverse alphabetical ordering.

that good or bad? 😁

@bouweandela
Copy link
Member

Alphabetical is nicer, but let's get this merged. I have no idea what codecov is thinking here..

@bouweandela bouweandela merged commit ef33a2d into main Nov 14, 2022
@bouweandela bouweandela deleted the remove_implicit_duplicate_setup branch November 14, 2022 13:40
@valeriupredoi
Copy link
Contributor Author

I thought you were the cov whisperer Bouwe 😆

@bouweandela
Copy link
Member

Thinking about it: the coverage change from #1769 is probably getting picked up because no coverage report was uploaded when that was merged into main because the tests failed on CircleCI.

@valeriupredoi
Copy link
Contributor Author

bingo 💡 That's it, man!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants