Pin pytest-mypy to less than 0.10.1
#1787
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1787 +/- ##
=======================================
Coverage 91.11% 91.11%
=======================================
Files 203 203
Lines 10908 10908
=======================================
Hits 9939 9939
Misses 969 969 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
OK fellas @schlunma @bouweandela dis ready for a merge 🔨 |
Co-authored-by: Manuel Schlund <32543114+schlunma@users.noreply.github.com>
schlunma
left a comment
schlunma
left a comment
There was a problem hiding this comment.
Looks good to me!
Please also open an issue about unpinning mypy after merging #1769 so that we don't forget this, this should only be a temporary solution.
@bouweandela please merge if you are happy with this procedure
schlunma
changed the title
pytest-mypy to not 0.10.1pytest-mypy to less than 0.10.1
|
great cheers Manu - this once merged we need to merge main in #1786 which has suddenly become very important 👍 |
zklaus
left a comment
zklaus
left a comment
There was a problem hiding this comment.
Let's not pin this, and instead follow the guidance at https://github.com/hauntsaninja/no_implicit_optional (which is linked from the error message) and simply set implicit_optional = True.
|
(Of course, better yet, fix our annotations following the same repo guidance, though that is marginally more effort.) |
|
OK so I close this then open an implicit ninja PR? 🥷 |
|
Or change it in this PR and change the title? 😄 |
naah, too much fuss - plus, it's good to have a cleaner closed PR than mess about with its history 👍 |
See if it sorts out test issues (I'll edit this PR description if we decide to merge this)
Edit: it do
@schlunma makes a good case for this PR to be merged in #1788 (comment)
Closes #1788