Skip to content

Conversation

@schlunma
Copy link
Contributor

@schlunma schlunma commented May 20, 2022

Description

This PR adds the derivation of hfns also used in the EMAC CMORizer in order to decrease the size of #1554.

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@schlunma schlunma added the variable derivation Related to variable derivation functions label May 20, 2022
@schlunma schlunma added this to the v2.6.0 milestone May 20, 2022
@schlunma schlunma self-assigned this May 20, 2022
@codecov
Copy link

codecov bot commented May 20, 2022

Codecov Report

Merging #1594 (d9c14d3) into main (b902e58) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1594      +/-   ##
==========================================
+ Coverage   90.83%   90.84%   +0.01%     
==========================================
  Files         200      201       +1     
  Lines       10648    10662      +14     
==========================================
+ Hits         9672     9686      +14     
  Misses        976      976              
Impacted Files Coverage Δ
esmvalcore/preprocessor/_derive/hfns.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b902e58...d9c14d3. Read the comment docs.

Copy link
Contributor

@remi-kazeroni remi-kazeroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me on the tech side, thanks @schlunma!

Copy link
Contributor

@axel-lauer axel-lauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@schlunma schlunma merged commit d023ff7 into main May 23, 2022
@schlunma schlunma deleted the derive_hfns branch May 23, 2022 11:08
@schlunma schlunma mentioned this pull request May 30, 2022
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

variable derivation Related to variable derivation functions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants