Pin cf-units and fix tests (cf-units>=2.1.5) #1140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valeriupredoi
changed the title
zklaus
approved these changes
May 21, 2021
Contributor
Author
|
cheers @zklaus 🍺 |
3 tasks
senesis
pushed a commit
that referenced
this pull request
Jun 7, 2021
* pin cf-units * pin cf-units * fix test * fix test
zklaus
pushed a commit
that referenced
this pull request
Jun 11, 2021
* Add basic support for variable mappings * Add first era5 mapping * Find files for CMIP6 DCPP startdates (#771) * First attempte * Do not require start and end years, add them later * Correct condition * Avoid key error in fx variables * Consider two possible paths * Fix function name * Fix variable name * Avoid duplicates in filename * Add test for startdate expansion * Add test for the replace tags method * Rename tag * Add documentation * Allow to load subexps per timerange or as a whole * Fix condition * Remove 'all_years' functionality * Fix conditions * Fix flake * Remove whitespace Co-authored-by: Javier Vegas-Regidor <[email protected]> * Skip regridding if the target grid is almost identical to the source grid (#507) Co-authored-by: Bouwe Andela <[email protected]> Co-authored-by: Stef Smeets <[email protected]> * Fixes for sos and siconc of BCC models (#1090) * sos and siconc fixed * tests added * test fixed * fix flake8 * fix flake8 * fix codacy issue * Pin cf-units and fix tests (cf-units>=2.1.5) (#1140) * pin cf-units * pin cf-units * fix test * fix test * Handle IPSL-CM6 (the feature won't actually work without #1124) * class Huss inherits from cass Tas. Also : Fix codacy diags. * Replace os.system() by subprocess.run() * Fix flake8 diags * var_mapping -> extra_facets * Rename _config/variable_details to _config/extra_facets * Fix doc re. lack of 'output_file as a dict', and choice of native6 * Fix codacy diags in ipsl_cm6.py * Use project IPSLCM to handle IPSL-CM6 * Implement changes according to Bouwe's review, 2021/06/07 (except unit tests) * Add unit tests for _fixes/ipslcm/ipsl_cm6.py * delete esmvalcore/cmor/_fixes/native6/ipsl_cm6.py * Delete old file esmvalcore/_config/extra_facets/native6-ipsl-cm6-mappings.yml * Restore main versions for _recipe.py and cmor_fixes/fix.py * Restore main version for _recipe.py * Delete extraneous era5-mappings.yml * Avoid using mapping_key when calling fix.get_cube_from_list() * Empty change in fix.py for forcing codacy to re-scan it * Polish doc * Polish doc again * Again... * and again ... * Fix typo in comment * Fixes according to @zklaus review * Reduce formatting changes * Update doc/develop/fixing_data.rst Co-authored-by: Klaus Zimmermann <[email protected]> * Update doc/develop/fixing_data.rst Co-authored-by: Klaus Zimmermann <[email protected]> * Update doc/develop/fixing_data.rst Co-authored-by: Klaus Zimmermann <[email protected]> * Update doc/develop/fixing_data.rst Co-authored-by: Klaus Zimmermann <[email protected]> * Update doc/develop/fixing_data.rst Co-authored-by: Klaus Zimmermann <[email protected]> * Update doc/develop/fixing_data.rst Co-authored-by: Klaus Zimmermann <[email protected]> * Update doc/develop/fixing_data.rst Co-authored-by: Klaus Zimmermann <[email protected]> * Update doc/quickstart/find_data.rst Co-authored-by: Klaus Zimmermann <[email protected]> * Update doc/quickstart/find_data.rst Co-authored-by: Klaus Zimmermann <[email protected]> * Minor formatting improvements * Organize mapping file in each realm in two sections (CMIP6 and IPSL) Co-authored-by: Klaus Zimmermann <[email protected]> Co-authored-by: sloosvel <[email protected]> Co-authored-by: Javier Vegas-Regidor <[email protected]> Co-authored-by: Benjamin Müller <[email protected]> Co-authored-by: Bouwe Andela <[email protected]> Co-authored-by: Stef Smeets <[email protected]> Co-authored-by: Rémi Kazeroni <[email protected]> Co-authored-by: Valeriu Predoi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
cf-time<2.1.5would introduce an empty space innum2datefor years that are <1000, whereas newercf-units>=2.1.5would not, hence two of our tests are failing as seen by Github Actions - this is a recurring problem since a few versions ago they were adding a 0 in front, hopefully next release they'll not add a horse 🐴Closes #issue_number
Link to documentation:
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: