-
Notifications
You must be signed in to change notification settings - Fork 44
Add basic support for variable mappings #1124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
50 commits
Select commit
Hold shift + click to select a range
154ab4a
Add basic support for variable mappings
363e75c
Move get_variable_mappings to _config
889173e
Add handling of mip and short_name to get_variable_mappings
204bd13
Move to new directory layout with importlib_resources
1b5fbd1
Introduce deep_update functionality
4cbb17b
Fix dataset handling
90ba75f
Use lowercase for project in filename
0cf7ad7
Allow for empty var_mapping to support existing fixes
3d5cbd8
Return empty dict instead of None to signal "no mappings"
97b0243
Change conditional import to work around mypy bug python/mypy#1153
3df52f5
Add importlib_resources to doc requirements
160e359
Improve code quality
69d7301
Add user config directory
c68aaf2
Move project variable mappings handling out of Recipe class
037422e
Add rudimentary docstring
b842a0b
Use variable details instead of variable mappings for better terminology
66a4480
Address renaming and logging suggestions
449daa6
Pass extra_facets through recipe to allow for easy customization
801c97b
Pre-commit changes
0624c7d
Pass extra_facets also to fx variables
3ff7376
Pre-commit changes
19bd7fb
Rename for consistency
857b726
Pre-commit changes
8037ec6
Add extra_facets_dir option to config_user.yml
b26362c
Add validator for new config option to experimental interface
2016c8b
Add mapping_key to get_cube_from_list for fixes
f8db25e
Simplify generation of tuple validator
5cf38c3
Pass entire variable dict to fix and add_fx_variables instead of onlyβ¦
1bb84e6
Don't check for exact argument match if the preprocessor takes *args β¦
7f60151
Fix recipe tests to check agains new, more comprehensive dicts
384d249
Remove extra_facets_dir from example config-user.yml file
6dae6ad
Add basic documentation
6a66072
Complete documentation
783298f
Fix test failing because of coverage upload
bouweandela 6dd52f8
Remove dubious caching
0a73a18
Add docstrings
ccf622e
Minor improvements
686c723
Add basic test for _deep_update
51d7f76
Add basic tests for _load_extra_facets
d8a42e3
Simplify handling of fx vars
75adca1
Fix mypy issues
004cafd
Remove mapping_key
f888f8d
Fix fx preprocessor test
79915cd
Improve formatting
731794e
Moving extra facet documentation to better places
3d362d0
Handle extra_facets as dictionary instead of kwargs where possible
99d5cfa
Add empty defaults to extra_facets to keep tests working
78e6e9e
Use better default for extra_facets in method signatures
9e24515
Update documentation with backlinks to main description
85918f2
Merge branch 'main' into variable-mappings
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,7 @@ | ||
| autodocsumm | ||
| dask[array] | ||
| fiona | ||
| importlib_resources | ||
| jinja2 | ||
| netCDF4 | ||
| numpy | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.