Skip to content

merge updates to esmf-weather-model#5

Merged
alperaltuntas merged 1 commit into
ESCOMP:dev/unifiedfrom
mvertens:feature/ufs-weather-model-update
Nov 19, 2022
Merged

merge updates to esmf-weather-model#5
alperaltuntas merged 1 commit into
ESCOMP:dev/unifiedfrom
mvertens:feature/ufs-weather-model-update

Conversation

@mvertens
Copy link
Copy Markdown

@mvertens mvertens commented Oct 5, 2022

Pull Request Summary

updates dev/unified to the EMC PR NOAA-EMC#780

Description

This PR updates dev/unified to the EMC PR NOAA-EMC#780
This PR MUST be accompanied by an accompanying PR to https://github.com/ESCOMP/WW3_interface which replaces hard coding of inputs to namelist input ww3_shel.nml .

Issue(s) addressed

None

Commit Message

updates dev/unified to the EMC PR NOAA-EMC#780

Check list

Testing

  • How were these changes tested?
  • Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
  • Have the matrix regression tests been run (if yes, please note HPC and compiler)?
  • Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):
  • Please indicate the expected changes in the regression test output (Note the known list of non-identical tests).
  • Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):

@mvertens mvertens added the enhancement New feature or request label Oct 5, 2022
@mvertens mvertens requested a review from alperaltuntas October 5, 2022 16:46
@mvertens mvertens marked this pull request as draft October 5, 2022 16:46
@mvertens mvertens marked this pull request as ready for review November 14, 2022 10:34
Copy link
Copy Markdown
Member

@alperaltuntas alperaltuntas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR doesn't pass our tests, but I'll go ahead and merge it and then follow up with a PR that fixes issues.

@alperaltuntas alperaltuntas merged commit 5b5ce40 into ESCOMP:dev/unified Nov 19, 2022
alperaltuntas added a commit that referenced this pull request Nov 19, 2022
@mvertens
Copy link
Copy Markdown
Author

@alperaltuntas - thank you for your work on this.

alperaltuntas added a commit that referenced this pull request Nov 19, 2022
@mvertens mvertens deleted the feature/ufs-weather-model-update branch July 14, 2023 12:56
francescococetta pushed a commit to francescococetta/WW3 that referenced this pull request Sep 26, 2023
fix sourcemods capability and pass hstokes back to mediator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants