Set KD=0, KV=0#135
Closed
dcherian wants to merge 2 commits into
Closed
Conversation
Closes ESCOMP#134
alperaltuntas
requested changes
Mar 30, 2023
Member
alperaltuntas
left a comment
alperaltuntas
left a comment
There was a problem hiding this comment.
We need to run the ./yaml_to_json script after making changes in yaml template files. This should have been caught by the CI test, but seems like the test is broken. I will create an issue.
4 tasks
Author
|
@ALDepp ran with these settings in it would be good to compare Gustavo's diagnostics with the previous baseline before merging here |
Collaborator
|
These changes were incorporated in #162 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #134