Supercedes #13 + updates to flags & mixing ratios#20
Closed
grantfirl wants to merge 14 commits into
Closed
Conversation
modified: standard_names.xml modified: Metadata-standard-names.md modified: standard_names.xml
remove duplication in UFS-based XML additions
address some comments; add duplication checker script
…me_helper.py script (in Grant's fork); address some (not all) comments
Add new standard name library generated from standard_name_helper.py
address 'time step' to 'timestep'
2021/7/1 update
changed the units of variables that start with volume_mixing_ratio to m3 m-3.
… ratios to be specific about denominators, constituent_mixing_ratio names
Collaborator
Author
grantfirl
requested review from
cacraigucar,
climbfuji,
gold2718 and
llpcarson
and removed request for
llpcarson
Collaborator
Author
This was a judgement call. I found it odd to give something with a floating point data type an "index" unit. I can change this if desired. |
Collaborator
|
if it's a number you can always default to unit '1'
… On Aug 20, 2021, at 12:05 PM, grantfirl ***@***.***> wrote:
Why units of none instead of index like the other control variables?
This was a judgement call. I found it odd to give something with a floating point data type an "index" unit. I can change this if desired.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub <#20 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB5C2RJ6OB2LY6RL6KQZ2V3T52KQNANCNFSM5CQYKKSQ>.
Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>.
|
Collaborator
I missed that detail. I agree that index should be reserved for integer values. |
Collaborator
Author
|
Closed since Weiwei merged the changed commit into her PR branch... Discussion/review should return to PR #13 now, I guess. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is basically PR #13 + 1 commit that fixes "flag" standard names and various mixing ratios. Commit d4d2c77 is the only difference between this and PR #13, but this PR is started since @bluefinweiwei is on PTO and the PR branch from #13 is in her fork.
Please only review commit d4d2c77 if you want this merged today. Otherwise, I can submit a PR with this commit into Weiwei's branch and we can continue with PR#13 next week. That commit contains the following previously-discussed changes: