generate_gdds: Get file lists earlier#3738
Merged
samsrabin merged 10 commits intoFeb 5, 2026
Merged
Conversation
samsrabin
added
b4b
samsrabin
commented
Feb 4, 2026
samsrabin
commented
Feb 4, 2026
samsrabin
commented
Feb 4, 2026
slevis-lmwg
approved these changes
Feb 4, 2026
Contributor
slevis-lmwg
left a comment
slevis-lmwg
left a comment
There was a problem hiding this comment.
@samsrabin I browsed through this, and I'm approving. Pls let me know if there are parts that you would like me to look at carefully or that you would like to discuss in a meeting.
samsrabin
removed
the
PR status: awaiting review
github-project-automation
Bot
moved this to Ready to start (or start again)
in CTSM: Upcoming tags
samsrabin
moved this from Ready to start (or start again)
to In progress - b4b-dev
in CTSM: Upcoming tags
github-project-automation
Bot
moved this from In progress - b4b-dev
to In progress - master
in CTSM: Upcoming tags
samsrabin
moved this from In progress - master
to In progress - b4b-dev
in CTSM: Upcoming tags
github-project-automation
Bot
moved this from In progress - b4b-dev
to Done (non release/external)
in CTSM: Upcoming tags
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Refactors
generate_gddsand its helper module so that file lists are generated early in the process. This makes it so that, if there are any files missing, errors will be thrown quickly.It also adds a lot of testing.
Specific notes
Contributors other than yourself, if any: None
CTSM Issues Fixed: None
Are answers expected to change (and if so in what way)? No
Any User Interface Changes (namelist or namelist defaults changes)? No
Does this create a need to change or add documentation? Did you do so? No
Testing performed, if any: Tested as part of my crop reparameterization work.
clm_pymodssuiterxcropmaturitysuite