Skip to content

post-5.4.n02.ctsm5.4.000: Fix for RRTMGP errors caused by high surface temperatures#3643

Merged
slevis-lmwg merged 6 commits into
ESCOMP:post-5.4from
olyson:RRTMGPfix
Dec 9, 2025
Merged

post-5.4.n02.ctsm5.4.000: Fix for RRTMGP errors caused by high surface temperatures#3643
slevis-lmwg merged 6 commits into
ESCOMP:post-5.4from
olyson:RRTMGPfix

Conversation

@olyson
Copy link
Copy Markdown
Contributor

@olyson olyson commented Dec 2, 2025

Description of changes

           ! Add esai to sa_leaf if elai is less than threshold.
           ! Intended to avoid small sa_leaf which leads to small leaf conductance
           ! and high leaf temperature. This in turn can lead to unrealistically
           ! high surface temperatures passed to the atmospheric model (The RRTMGP
           ! component in particular, which returns an error and stops the model
           ! if the surface temperature is greater than 355K).
           ! See https://github.com/ESCOMP/CTSM/issues/3589 for more info.
           ! The 0.1_r8 value is fairly arbitrary but has been effective in
           ! avoiding RRTMGP errors in CESM3 development simulations.

Specific notes

Contributors other than yourself, if any: @swensosc , @slevis-lmwg

CTSM Issues Fixed (include github issue #): #3589

Are answers expected to change (and if so in what way)? Yes (similar climate though)

Any User Interface Changes (namelist or namelist defaults changes)? No

Does this create a need to change or add documentation? Did you do so? Yes. No.

Testing performed, if any:
See #3589 for testing description. I have not run any CTSM system testing.

Copy link
Copy Markdown
Contributor

@slevis-lmwg slevis-lmwg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. I will start aux_clm to confirm nothing's broken. Also I will try rebasing to the post-5.4 branch to get this in more efficiently.

@slevis-lmwg slevis-lmwg added the non-b4b Changes answers (incl. adding tests) label Dec 3, 2025
@slevis-lmwg slevis-lmwg changed the base branch from master to post-5.4 December 3, 2025 16:50
@slevis-lmwg slevis-lmwg changed the base branch from post-5.4 to master December 3, 2025 16:52
@slevis-lmwg
Copy link
Copy Markdown
Contributor

Rebasing didn't work, as it ended up with 44 files changed, so I reverted to master. I thought rebasing would apply the same changes but starting from post-5.4 instead of starting from master. Clearly there's something about rebasing that I don't get, because sometimes it does what I expect and sometimes not.

Maybe if I update the post_5.4 branch to ctsm5.3.085? I will think about it. I will hold off on aux_clm for now.

Copy link
Copy Markdown
Contributor

@ekluzek ekluzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olyson thanks so much for figuring this out.

I had some simple suggestions. But, then when I looked closer I saw some other things that I think need to be done. And I then saw a way to make the code both clearer to humans and more maintainable so that the contents of the if blocks didn't need to be matched if something changed. So I think it's all worth doing.

Comment thread src/biogeophys/CanopyFluxesMod.F90 Outdated
Comment thread src/biogeophys/CanopyFluxesMod.F90
Comment thread src/biogeophys/CanopyFluxesMod.F90
@swensosc
Copy link
Copy Markdown
Contributor

swensosc commented Dec 3, 2025 via email

Comment thread src/biogeophys/CanopyFluxesMod.F90 Outdated
@slevis-lmwg slevis-lmwg moved this from In Progress to Stalled in LMWG: Sprint Planning Board Dec 3, 2025
@github-project-automation github-project-automation Bot moved this to Ready to start (or start again) in CTSM: Upcoming tags Dec 4, 2025
@github-project-automation github-project-automation Bot moved this from Ready to start (or start again) to In progress - master in CTSM: Upcoming tags Dec 4, 2025
@samsrabin samsrabin changed the title Fix for RRTMGP errors caused by high surface temperatures. Post-5.4: Fix for RRTMGP errors caused by high surface temperatures. Dec 4, 2025
@samsrabin samsrabin moved this from In progress - master to In progress - release/externals / MOSART / RTM / mizu etc. tags in CTSM: Upcoming tags Dec 4, 2025
@samsrabin samsrabin added this to the cesm3_0_beta08 milestone Dec 4, 2025
@samsrabin samsrabin changed the base branch from master to post-5.4 December 4, 2025 17:55
@samsrabin samsrabin changed the base branch from post-5.4 to master December 4, 2025 17:56
@slevis-lmwg slevis-lmwg moved this from Stalled to In Progress in LMWG: Sprint Planning Board Dec 8, 2025
@slevis-lmwg
Copy link
Copy Markdown
Contributor

I will try merging the latest from post-5.4 (tag post-5.4.n01.alpha-ctsm5.4.CMIP7.21.ctsm5.3.085) and rebasing to post-5.4. If all that works, then I can start the test-suites.

@ekluzek ekluzek changed the base branch from master to post-5.4 December 8, 2025 21:03
I think I'm merging what should be tag
post-5.4.n01.alpha-ctsm5.4.CMIP7.21.ctsm5.3.085
@slevis-lmwg
Copy link
Copy Markdown
Contributor

slevis-lmwg commented Dec 9, 2025

./run_sys_tests -s aux_clm -c post-5.4.n01.alpha-ctsm5.4.CMIP7.21.ctsm5.3.085 -g post-5.4.n02.ctsm5.4.000
derecho and izumi OK: BASELINE post-5.4.n01.alpha-ctsm5.4.CMIP7.21.ctsm5.3.085: DIFF

I looked at the cprnc file of the shortest tests (Ln9, Ld2) e.g.:
SMS_Ln9.ne3pg3_ne3pg3_mt232.I2000Clm60Sp.derecho_gnu.clm-clm60cam7LndTuningMode--clm-nofireemis.GC.1208-175929de_gnu/SMS_Ln9.ne3pg3_ne3pg3_mt232.I2000Clm60Sp.derecho_gnu.clm-clm60cam7LndTuningMode--clm-nofireemis.GC.1208-175929de_gnu.cpl.hi.2000-01-01-16200.nc.cprnc.out
All fields with diffs (greater than roundoff but small) have prefixes lnd[Imp,Exp] and rof[Imp,Exp].

@slevis-lmwg
Copy link
Copy Markdown
Contributor

Keith and I looked at diffs in a 2-yr test (fields FSH, FIRE, TV, TG), and Keith approved the changes that we saw.

@slevis-lmwg slevis-lmwg merged commit f5e1542 into ESCOMP:post-5.4 Dec 9, 2025
4 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in LMWG: Sprint Planning Board Dec 9, 2025
@github-project-automation github-project-automation Bot moved this from In progress - release/externals / MOSART / RTM / mizu etc. tags to Done (non release/external) in CTSM: Upcoming tags Dec 9, 2025
@slevis-lmwg slevis-lmwg deleted the RRTMGPfix branch December 9, 2025 19:34
@slevis-lmwg slevis-lmwg moved this from Done (non release/external) to release/externals tags done in CTSM: Upcoming tags Dec 9, 2025
@slevis-lmwg slevis-lmwg changed the title Post-5.4: Fix for RRTMGP errors caused by high surface temperatures. post-5.4.n02.ctsm5.4.000: Fix for RRTMGP errors caused by high surface temperatures Dec 9, 2025
@slevis-lmwg slevis-lmwg moved this from release/externals tags done to Done (non release/external) in CTSM: Upcoming tags Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

non-b4b Changes answers (incl. adding tests)

Projects

Status: Done (non release/external)
Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants