Skip to content

post-5.4.n00: New crop calendar inputs and updated params (omni02)#3618

Merged
samsrabin merged 5 commits into
ESCOMP:post-5.4from
samsrabin:crop-newcals-and-omni02
Nov 22, 2025
Merged

post-5.4.n00: New crop calendar inputs and updated params (omni02)#3618
samsrabin merged 5 commits into
ESCOMP:post-5.4from
samsrabin:crop-newcals-and-omni02

Conversation

@samsrabin
Copy link
Copy Markdown
Member

@samsrabin samsrabin commented Nov 20, 2025

Description of changes

Updated crop maturity requirements and GDD20 baselines using improved scripts and CRU-JRA forcing.

Calibrating crop parameters looking at yield for about 1995-2005 while minimizing failed seasons:

  • Corn: Don't change anything. It's high for 2000-2010 but looks good after that.
  • Cotton: Increase max growing season length from 160 days to 270 days. Causes overwintering, so this will probably need to be reverted! But useful for now to explore how much an extreme change could help with the high failure rate.
  • Rice: Revert CLM5 arooti changes.
  • Soybean: It's low for this period but nothing I tried helped much. Removing mxmat helped a bit, so increase max growing season length from 150 days to 180 days. Accidentally did this for rice instead! Will revert in next crop parameter PR.
  • Sugarcane: Increase max growing season length from 300 days to 360.
  • Wheat: Revert CLM5 arooti changes. Need a pretty big drop in yields and this didn't do it in my test, but that was without grainfill triggering max LAI and thus much more failed crop area. (There were no crop phase parameter changes in CLM5.)

Specific notes

Contributors other than yourself, if any: None

CTSM Issues Fixed:

Are answers expected to change (and if so in what way)? Yes: Any CLM6 crop compset.

Any User Interface Changes (namelist or namelist defaults changes)? New:

  • clm6_0 paramfile
  • Non-GSWP3 stream_fldfilename_cultivar_gdds
  • Non-GSWP3 stream_gdd20_seasons = .false. stream_fldFileName_gdd20_baseline.

Does this create a need to change or add documentation? Did you do so? No

Testing performed, if any:

  • aux_clm in progress
  • Two build-namelist tests fail; I'm assuming these aren't my fault:
1137/3396 < FAIL> <Test Id: 1137> <Desc: useFATESLUH2fileDNE>
1144/3396 < FAIL> <Test Id: 1144> <Desc: inventoryfileDNE>

Derived from half-degree run started 1959-01-01, forced with CRU-JRA, at tag alpha-ctsm5.4.CMIP7.15.ctsm5.3.079. Growing seasons defined by files [sh]dates_ggcmi_crop_calendar_phase3_v1.01_nninterp-hcru_hcru_mt13.2000-2000.20230728_165845.nc. Maximum growing season length in generate_gdds.py derived from mxmat in clm60_params.crop_omni02.c251120.nc with no 'cushion'. generate_gdds.py first season 1995 and last season 2005.
Derived from half-degree run started 1959-01-01, forced with CRU-JRA, at tag alpha-ctsm5.4.CMIP7.15.ctsm5.3.079. generate_gdd20_baseline -v GDDB20 -y1 1995 -yN 2005.
@samsrabin samsrabin added this to the ctsm6.0.0 (code freeze) milestone Nov 20, 2025
@samsrabin samsrabin self-assigned this Nov 20, 2025
@samsrabin samsrabin added the enhancement new capability or improved behavior of existing capability label Nov 20, 2025
@samsrabin samsrabin added science Enhancement to or bug impacting science non-b4b Changes answers (incl. adding tests) labels Nov 20, 2025
@samsrabin samsrabin marked this pull request as ready for review November 20, 2025 23:58
@samsrabin samsrabin changed the title New crop calendar inputs and updated params (omni02) post-5.4.n00: New crop calendar inputs and updated params (omni02) Nov 21, 2025
Copy link
Copy Markdown
Contributor

@slevis-lmwg slevis-lmwg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samsrabin I looked at your changes. They seem simple enough. Approving.

Copy link
Copy Markdown
Contributor

@ekluzek ekluzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a couple comments/questions, but this looks good to go. My comments should be addressed in a possible later step. Most of the work was in creating the new datasets that you point to here. So this is deceptively simple compared to the loads of work it took you to get the datasets ready.

Comment thread bld/namelist_files/namelist_defaults_ctsm.xml
Comment thread bld/namelist_files/namelist_defaults_ctsm.xml
Comment thread bld/CLMBuildNamelist.pm
@samsrabin samsrabin merged commit 47c7e92 into ESCOMP:post-5.4 Nov 22, 2025
4 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in CTSM: Crop enhancements Nov 22, 2025
@samsrabin
Copy link
Copy Markdown
Member Author

Meant to include some figures before submitting, but here they are for posterity:

screenshot_4874

Successfully reduced failing seasons:
screenshot_4875

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement new capability or improved behavior of existing capability non-b4b Changes answers (incl. adding tests) science Enhancement to or bug impacting science

Projects

Development

Successfully merging this pull request may close these issues.

4 participants