Skip to content

alpha-ctsm5.4.CMIP7.18.ctsm5.3.082: fsurdat validation tool#3612

Merged
slevis-lmwg merged 2 commits into
ESCOMP:alpha-ctsm5.4.CMIP7from
slevis-lmwg:fsurdat_validation_tool
Nov 18, 2025
Merged

alpha-ctsm5.4.CMIP7.18.ctsm5.3.082: fsurdat validation tool#3612
slevis-lmwg merged 2 commits into
ESCOMP:alpha-ctsm5.4.CMIP7from
slevis-lmwg:fsurdat_validation_tool

Conversation

@slevis-lmwg
Copy link
Copy Markdown
Contributor

Script that helps with fsurdat validation as we go from ctsm5.3 to ctsm5.4 datasets.

@slevis-lmwg slevis-lmwg self-assigned this Nov 14, 2025
@slevis-lmwg slevis-lmwg added the b4b bit-for-bit label Nov 14, 2025
@github-project-automation github-project-automation Bot moved this to Ready to start (or start again) in CTSM: Upcoming tags Nov 14, 2025
@slevis-lmwg slevis-lmwg moved this from Ready to start (or start again) to In progress - release/externals / MOSART / RTM / mizu etc. tags in CTSM: Upcoming tags Nov 14, 2025
@slevis-lmwg slevis-lmwg changed the title fsurdat validation tool alpha-ctsm5.4.CMIP7.18.ctsm5.3.082: fsurdat validation tool Nov 14, 2025
@slevis-lmwg slevis-lmwg requested a review from ekluzek November 14, 2025 23:31
@slevis-lmwg
Copy link
Copy Markdown
Contributor Author

@ekluzek I requested a review of this PR from you. This adds the script that runs cprnc on a variety of grids and then greps for RMS and/or NORMALIZED diffs that are >= 1.

Copy link
Copy Markdown
Contributor

@ekluzek ekluzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. I have some suggestions for readability and making it more useful for the next time this is needed. We want to preserve what was done here to validate ctsm5.4.000, but some changes will help with readability as well as making it useful the next time.

Comment thread tools/mksurfdata_esmf/validate_fsurdat_files.sh Outdated
Comment thread tools/mksurfdata_esmf/validate_fsurdat_files.sh
Comment thread tools/mksurfdata_esmf/validate_fsurdat_files.sh
Comment thread tools/mksurfdata_esmf/validate_fsurdat_files.sh Outdated
Comment thread tools/mksurfdata_esmf/validate_fsurdat_files.sh Outdated
Comment thread tools/mksurfdata_esmf/validate_fsurdat_files.sh
Comment thread tools/mksurfdata_esmf/validate_fsurdat_files.sh Outdated
Comment thread tools/mksurfdata_esmf/validate_fsurdat_files.sh Outdated
Comment thread tools/mksurfdata_esmf/validate_fsurdat_files.sh
Comment thread tools/mksurfdata_esmf/validate_fsurdat_files.sh Outdated
@github-project-automation github-project-automation Bot moved this from In progress - release/externals / MOSART / RTM / mizu etc. tags to Stalled (needs review, blocked etc.) in CTSM: Upcoming tags Nov 17, 2025
Comment thread tools/mksurfdata_esmf/validate_fsurdat_files.sh
@slevis-lmwg slevis-lmwg requested a review from ekluzek November 18, 2025 19:23
@slevis-lmwg
Copy link
Copy Markdown
Contributor Author

Thank you @ekluzek! I have requested from you a review of my revisions to the script.

Copy link
Copy Markdown
Contributor

@ekluzek ekluzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. I like the additions of the comment about # USER DEFINED.

@github-project-automation github-project-automation Bot moved this from Stalled (needs review, blocked etc.) to In progress - master in CTSM: Upcoming tags Nov 18, 2025
@ekluzek
Copy link
Copy Markdown
Contributor

ekluzek commented Nov 18, 2025

@slevis-lmwg I added a section to the "Minor Version Update" wiki page on the updating surface datasets process:

https://github.com/ESCOMP/CTSM/wiki/Minor-Version-Update-Protocols#when-surface-datasets-are-being-updated

It lays out the standard steps that need to be done for surface dataset updates.

Please review and make changes or point them out to me to update.

@slevis-lmwg
Copy link
Copy Markdown
Contributor Author

@slevis-lmwg I added a section to the "Minor Version Update" wiki page on the updating surface datasets process:

https://github.com/ESCOMP/CTSM/wiki/Minor-Version-Update-Protocols#when-surface-datasets-are-being-updated

It lays out the standard steps that need to be done for surface dataset updates.

Please review and make changes or point them out to me to update.

Thank you for this @ekluzek. I made minor changes if you want to look.

@slevis-lmwg slevis-lmwg merged commit a5b18cc into ESCOMP:alpha-ctsm5.4.CMIP7 Nov 18, 2025
4 checks passed
@github-project-automation github-project-automation Bot moved this from In progress - master to Done (non release/external) in CTSM: Upcoming tags Nov 18, 2025
@slevis-lmwg
Copy link
Copy Markdown
Contributor Author

github operations are down, so I will continue later with step 8 in doc/README.CHECKLIST.master_tags

@slevis-lmwg slevis-lmwg moved this from Done (non release/external) to release/externals tags done in CTSM: Upcoming tags Nov 18, 2025
@slevis-lmwg slevis-lmwg deleted the fsurdat_validation_tool branch November 18, 2025 22:04
slevis-lmwg added a commit to slevis-lmwg/ctsm that referenced this pull request Nov 18, 2025
…release_notes

Add fsurdat validation tool to mksurfdata_esmf directory

PR ESCOMP#3612
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

b4b bit-for-bit

Projects

Status: release/externals tags done

Development

Successfully merging this pull request may close these issues.

2 participants