Skip to content

Finishing adding RC14_CANAIR history output#3548

Merged
ekluzek merged 3 commits into
ESCOMP:b4b-devfrom
ekluzek:rc14_canair
Oct 15, 2025
Merged

Finishing adding RC14_CANAIR history output#3548
ekluzek merged 3 commits into
ESCOMP:b4b-devfrom
ekluzek:rc14_canair

Conversation

@ekluzek
Copy link
Copy Markdown
Contributor

@ekluzek ekluzek commented Oct 14, 2025

Description of changes

Bring in addition of RC14_CANAIR on history so that Carbon isotope data reading can be validated.

Specific notes

Contributors other than yourself, if any:

CTSM Issues Fixed (include github issue #):
Fixes #3490
Fixes #3488

Are answers expected to change (and if so in what way)? No

Any User Interface Changes (namelist or namelist defaults changes)? Add RC14_CANAIR as an output history option

Does this create a need to change or add documentation? Did you do so? No No

Testing performed, if any: So far ran SMS_Ly3.f10_f10_mt232.IHistClm60BgcCropCrujra.derecho_intel.clm-monthly--clm-clm60cam7LndTuningMode_2013Start
Will run complete test suite

@ekluzek ekluzek requested a review from slevis-lmwg October 14, 2025 21:23
@ekluzek ekluzek self-assigned this Oct 14, 2025
@ekluzek ekluzek added enhancement new capability or improved behavior of existing capability code health improving internal code structure to make easier to maintain (sustainability) b4b bit-for-bit usability Improve or clarify user-facing options labels Oct 14, 2025
Copy link
Copy Markdown
Contributor

@slevis-lmwg slevis-lmwg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ekluzek thank you. You'll see a few comments in my review, mainly in the form of questions.

Comment thread src/biogeophys/PhotosynthesisMod.F90
Comment thread src/biogeophys/PhotosynthesisMod.F90
Comment thread src/biogeophys/PhotosynthesisMod.F90
@ekluzek ekluzek changed the base branch from master to b4b-dev October 15, 2025 03:52
@ekluzek
Copy link
Copy Markdown
Contributor Author

ekluzek commented Oct 15, 2025

@slevis-lmwg it looks like you didn't hit the approval part. I could override, but I'll wait for you to hit approval.

Copy link
Copy Markdown
Contributor

@slevis-lmwg slevis-lmwg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ekluzek thank you for addressing my questions/concerns. Now I am selecting the Approve option.

Comment thread src/biogeophys/PhotosynthesisMod.F90
@ekluzek ekluzek merged commit e1637a7 into ESCOMP:b4b-dev Oct 15, 2025
6 checks passed
@ekluzek ekluzek deleted the rc14_canair branch October 15, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

b4b bit-for-bit code health improving internal code structure to make easier to maintain (sustainability) enhancement new capability or improved behavior of existing capability usability Improve or clarify user-facing options

Projects

Status: Done

2 participants