Endrun work#3418
Merged
Merged
Conversation
ekluzek
added
the
enhancement
ekluzek
added
code health
…plicit tests for subgrid levels not supported: lndgrid and cohort and for unspecified, right now these fail
…or messaging gives as much information as possible about the error, also reuse the endrun_vanilla in the pt_context version to remove duplication
…ubgrid_level, but the original error sent in, this and the previous commit resolve ESCOMP#3420
…and add an option to it to avoid the abort, which is needed when it's used from an endrun call with pt_context
…sg if both are present
… show it still works even if only one is present
Contributor
Author
|
@samsrabin this has everything I need in it. unit tests are fine on Derecho. I'm running aux_clm testing now. |
Contributor
Author
|
aux_clm on Derecho and Izumi are as expected. |
samsrabin
approved these changes
Aug 18, 2025
Member
samsrabin
left a comment
samsrabin
left a comment
There was a problem hiding this comment.
Looks good, thanks! Just some minor requests; I'll approve in advance.
…e statement, for notes that are specific to a line in the subroutine, add NOTE: to most of them in response to review
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Add a unit test to endrun, so I can do a little work on it, and use those improvements in the decompInit work.
Specific notes
Contributors other than yourself, if any:
CTSM Issues Fixed (include github issue #):
Fixes #3417
Fixes #3420
Are answers expected to change (and if so in what way)? No
Any User Interface Changes (namelist or namelist defaults changes)? No
Does this create a need to change or add documentation? Did you do so? No No
Testing performed, if any: So far running unit tests will run aux_clm