Make npcropmin/max private to pftconMod#3390
Merged
Merged
Conversation
0a5b9ef to
dfff3c0
Compare
dfff3c0 to
b50faf2
Compare
slevis-lmwg
approved these changes
Aug 18, 2025
Contributor
slevis-lmwg
left a comment
There was a problem hiding this comment.
I made two minor suggestions, and I am approving preemptively. Thank you @samsrabin for this work!
Co-authored-by: Samuel Levis <slevis@ucar.edu>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Making
npcropminandnpcropmaxprivate topftconModhelps set up for adding anis_prognostic_cropparameter to the parameter file, contributing to #3388. Making these private required adding anis_prognostic_crop()function, the contents of which will eventually be replaced by a read of that new parameter.Specific notes
Contributors other than yourself, if any: None
CTSM Issues Fixed:
Are answers expected to change (and if so in what way)? No
Any User Interface Changes (namelist or namelist defaults changes)? No
Does this create a need to change or add documentation? Did you do so? No
Testing performed, if any:
aux_clmpasses