Skip to content

Make npcropmin/max private to pftconMod#3390

Merged
samsrabin merged 10 commits into
ESCOMP:b4b-devfrom
samsrabin:private-npcropminmax
Aug 19, 2025
Merged

Make npcropmin/max private to pftconMod#3390
samsrabin merged 10 commits into
ESCOMP:b4b-devfrom
samsrabin:private-npcropminmax

Conversation

@samsrabin
Copy link
Copy Markdown
Member

@samsrabin samsrabin commented Aug 6, 2025

Description of changes

Making npcropmin and npcropmax private to pftconMod helps set up for adding an is_prognostic_crop parameter to the parameter file, contributing to #3388. Making these private required adding an is_prognostic_crop() function, the contents of which will eventually be replaced by a read of that new parameter.

Specific notes

Contributors other than yourself, if any: None

CTSM Issues Fixed:

Are answers expected to change (and if so in what way)? No

Any User Interface Changes (namelist or namelist defaults changes)? No

Does this create a need to change or add documentation? Did you do so? No

Testing performed, if any:

  • aux_clm passes

@samsrabin samsrabin self-assigned this Aug 6, 2025
@samsrabin samsrabin added code health improving internal code structure to make easier to maintain (sustainability) b4b bit-for-bit labels Aug 6, 2025
@samsrabin samsrabin force-pushed the private-npcropminmax branch 2 times, most recently from 0a5b9ef to dfff3c0 Compare August 7, 2025 21:58
@samsrabin samsrabin force-pushed the private-npcropminmax branch from dfff3c0 to b50faf2 Compare August 7, 2025 23:15
@samsrabin samsrabin changed the title [WIP] Make npcropmin/max private to pftconMod Make npcropmin/max private to pftconMod Aug 8, 2025
@samsrabin samsrabin marked this pull request as ready for review August 8, 2025 21:48
@samsrabin samsrabin added the PR status: awaiting review Work on this PR is paused while waiting for review. label Aug 8, 2025
@github-project-automation github-project-automation Bot moved this to Ready to start (or start again) in CTSM: Upcoming tags Aug 8, 2025
@samsrabin samsrabin moved this from Ready to start (or start again) to In progress - b4b-dev in CTSM: Upcoming tags Aug 8, 2025
@samsrabin samsrabin added the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Aug 11, 2025
@samsrabin samsrabin moved this from In progress - b4b-dev to Stalled (needs review, blocked etc.) in CTSM: Upcoming tags Aug 14, 2025
@samsrabin samsrabin moved this from Stalled (needs review, blocked etc.) to In progress - b4b-dev in CTSM: Upcoming tags Aug 14, 2025
@samsrabin samsrabin removed the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Aug 14, 2025
@samsrabin samsrabin requested a review from slevis-lmwg August 18, 2025 16:10
Copy link
Copy Markdown
Contributor

@slevis-lmwg slevis-lmwg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made two minor suggestions, and I am approving preemptively. Thank you @samsrabin for this work!

Comment thread src/biogeochem/CNFUNMod.F90 Outdated
Comment thread src/main/pftconMod.F90 Outdated
@github-project-automation github-project-automation Bot moved this from In progress - b4b-dev to In progress - master in CTSM: Upcoming tags Aug 18, 2025
@samsrabin samsrabin removed the PR status: awaiting review Work on this PR is paused while waiting for review. label Aug 19, 2025
@samsrabin samsrabin merged commit 8d8be78 into ESCOMP:b4b-dev Aug 19, 2025
4 checks passed
@github-project-automation github-project-automation Bot moved this from In progress - master to Done (non release/external) in CTSM: Upcoming tags Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

b4b bit-for-bit code health improving internal code structure to make easier to maintain (sustainability)

Projects

Status: Done (non release/external)

Development

Successfully merging this pull request may close these issues.

2 participants