Tech Note: Distinguish between time step and iteration level in vegetation longwave and fluxes#3220
Conversation
olyson
added
documentation
samsrabin
changed the title
|
Immediately after an upcoming b4b-dev merge to master, I would update this PR to the latest master and rebase to b4b-dev. |
|
@slevis-lmwg Mind if I ask why? This seems independent of anything else on b4b-dev or master. |
|
@samsrabin you were correct, rebasing did not mess anything up, thanks! |
olyson
added
the
next
|
@slevis-lmwg can you review? |
|
Sure, will do. |
|
Actually, @slevis-lmwg says he won't be able to get to it today, so it'll come in next time. |
slevis-lmwg
left a comment
slevis-lmwg
left a comment
There was a problem hiding this comment.
@samsrabin pls check whether I pointed out actual or only perceived inconsistencies.
|
@olyson Please ping me when this is ready for review and I'll do a test build. |
@samsrabin , this can be re-reviewed. Thanks! |
slevis-lmwg
left a comment
slevis-lmwg
left a comment
There was a problem hiding this comment.
Happy to approve (without looking in detail this time).
samsrabin
left a comment
samsrabin
left a comment
There was a problem hiding this comment.
Actually, I see now a test failed... Checking.
samsrabin
left a comment
samsrabin
left a comment
There was a problem hiding this comment.
Huh. Now I'm not seeing the failed test. Approving.
samsrabin
removed
the
next
4 participants
Description of changes
Distinguish between time step and iteration level in vegetation longwave and fluxes tech note documentation
Specific notes
Contributors other than yourself, if any: @bishtgautam
CTSM Issues Fixed (include github issue #):
Are answers expected to change (and if so in what way)? No
Any User Interface Changes (namelist or namelist defaults changes)? No
Does this create a need to change or add documentation? Did you do so? Yes, yes.
Testing performed, if any:
Built and view documentation locally.