Skip to content

Fix #3110 (Initialization of historical using CTSM5.4 surface datasets fails)#3132

Merged
ekluzek merged 17 commits into
ESCOMP:b4b-devfrom
olyson:b4b-dev_init_interp_urb
Jul 10, 2025
Merged

Fix #3110 (Initialization of historical using CTSM5.4 surface datasets fails)#3132
ekluzek merged 17 commits into
ESCOMP:b4b-devfrom
olyson:b4b-dev_init_interp_urb

Conversation

@olyson
Copy link
Copy Markdown
Contributor

@olyson olyson commented May 14, 2025

Description of changes

If a urban tall building district (TBD) type is not found in the input restart file and TBD type is required by init_interp, allow the user to specify init_interp_fill_missing_urban_with_HD = .true. in order to fill TBD in the init_interp output file with urban high density (HD), utilizing the init_interp routines.

Specific notes

Contributors other than yourself, if any: @ekluzek

CTSM Issues Fixed (include github issue #):
Fixes #3110

Are answers expected to change (and if so in what way)? No

Any User Interface Changes (namelist or namelist defaults changes)? Yes

Does this create a need to change or add documentation? Did you do so? Yes. No.

Testing performed, if any:
Nothing yet.

Definition of done:

  • Remove hardcoded indices for columns if possible
  • Clarify the second _abort test name
  • Make sure unit testing continues to work
  • @ekluzek Copy test files to inputdata and rimport them
  • @ekluzek add new system test to aux_clm
  • @ekluzek Update to latest b4b-dev branch
  • @ekluzek test aux_clm on Derecho and Izumi

@ekluzek ekluzek added enhancement new capability or improved behavior of existing capability b4b bit-for-bit science Enhancement to or bug impacting science usability Improve or clarify user-facing options labels May 14, 2025
@github-project-automation github-project-automation Bot moved this to Ready to start (or start again) in CTSM: Upcoming tags May 14, 2025
@ekluzek ekluzek added this to the ctsm5.4.0: CMIP7 Datasets milestone May 14, 2025
@ekluzek ekluzek added the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label May 22, 2025
@ekluzek ekluzek marked this pull request as ready for review May 22, 2025 20:50
@ekluzek ekluzek self-requested a review May 22, 2025 20:50
@wwieder wwieder removed the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label May 22, 2025
@wwieder wwieder mentioned this pull request May 28, 2025
5 tasks
@wwieder wwieder moved this from Status not assigned to Prioritized in CTSM: release-ctsm5.4 minor version update (CMIP7 datasets) May 28, 2025
@wwieder wwieder moved this from Todo to In Progress in LMWG: Sprint Planning Board May 28, 2025
@wwieder wwieder linked an issue May 28, 2025 that may be closed by this pull request
21 tasks
@wwieder wwieder linked an issue May 28, 2025 that may be closed by this pull request
5 tasks
@wwieder wwieder linked an issue May 29, 2025 that may be closed by this pull request
2 tasks
Copy link
Copy Markdown
Contributor

@ekluzek ekluzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. I have some small suggestions that I think will be useful. I think we have the tests covered that need to be here.

I'm approving so you don't need to wait on me.

Comment thread src/init_interp/initInterpMindist.F90 Outdated
Comment thread src/init_interp/test/initInterpMindist_test/test_set_mindist.pf Outdated
Comment thread src/init_interp/test/initInterpMindist_test/test_set_mindist.pf Outdated
Comment thread src/init_interp/test/initInterpMindist_test/test_set_mindist.pf
Comment thread src/init_interp/test/initInterpMindist_test/test_set_mindist.pf Outdated
Comment thread src/init_interp/test/initInterpMindist_test/test_set_mindist.pf
@github-project-automation github-project-automation Bot moved this from Ready to start (or start again) to In progress - master in CTSM: Upcoming tags Jun 5, 2025
Comment thread src/init_interp/initInterpMindist.F90
Comment thread src/init_interp/test/initInterpMindist_test/test_set_mindist.pf
@ekluzek
Copy link
Copy Markdown
Contributor

ekluzek commented Jun 5, 2025

In meeting. Pain points are familiarity with the unit testing and specifically the subtlety mentioned above regarding the array index to check, and the error testing for an expected error message. Need some wiki pages or dev guide instructions on this.

@olyson said he sees the value, he was able to figure out how to get it to work on his own, and would do again.

@ekluzek
Copy link
Copy Markdown
Contributor

ekluzek commented Jun 11, 2025

Cool, this is great @olyson. I'll look at that last conversation, and see if there's anything I come up with. But, this completes your part of this, and then I'll do my parts and send it to b4b-dev. Thanks so much!

@ekluzek
Copy link
Copy Markdown
Contributor

ekluzek commented Jul 10, 2025

Testing for aux_clm on Derecho and Izumi is done and looks good.

@ekluzek ekluzek merged commit ad64068 into ESCOMP:b4b-dev Jul 10, 2025
4 checks passed
@github-project-automation github-project-automation Bot moved this from In progress - b4b-dev to Done (non release/external) in CTSM: Upcoming tags Jul 10, 2025
@github-project-automation github-project-automation Bot moved this from In Progress to Done in LMWG: Sprint Planning Board Jul 10, 2025
@ekluzek ekluzek deleted the b4b-dev_init_interp_urb branch July 10, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

b4b bit-for-bit enhancement new capability or improved behavior of existing capability PR status: needs testing science Enhancement to or bug impacting science usability Improve or clarify user-facing options

Projects

Status: Done (non release/external)
Status: Done

4 participants