Fix ctsm-docs container version tagging#3128
Merged
Merged
Conversation
samsrabin
commented
May 13, 2025
samsrabin
commented
May 13, 2025
samsrabin
commented
May 13, 2025
We should avoid relying on the "latest" tag for anything, but it's good practice to have one.
Requires updating version to v1.0.2, even though the container won't actually change.
757932a to
dd730c2
Compare
22f300b to
fd6d7c9
Compare
samsrabin
commented
May 13, 2025
samsrabin
commented
May 13, 2025
samsrabin
commented
May 13, 2025
samsrabin
commented
May 13, 2025
samsrabin
commented
May 13, 2025
ekluzek
approved these changes
May 15, 2025
ekluzek
left a comment
Contributor
There was a problem hiding this comment.
@samsrabin and I went over this in depth. This is good work, and the changes make sense, and are needed for what happens.
This will be something that CTSM SE developers might need to work with on occasion and there's documentation on how to do the basic things. The whole package has complexity to it, but we likely won't need to modify it very often. I'm glad @samsrabin has developed expertise in this area, and we will undoubtably use that for other things as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
The GitHub workflow that builds and pushes new versions of the ctsm-docs container doesn't include a tag with the version number. This PR fixes that. It also checks that the included version tag is formatted correctly and hasn't been used before.
Specific notes
Contributors other than yourself, if any: None
CTSM Issues Fixed:
Are answers expected to change (and if so in what way)? No
Any User Interface Changes (namelist or namelist defaults changes)? No
Does this create a need to change or add documentation? Did you do so? Yes, the README.md file next to the Dockerfile; yes.
Testing performed, if any: Tested at https://github.com/samsrabin/test-CTSM-docs-version-tagging: