Skip to content

Fix ctsm-docs container version tagging#3128

Merged
samsrabin merged 13 commits into
ESCOMP:b4b-devfrom
samsrabin:ctsm-docs-version-tagging
May 16, 2025
Merged

Fix ctsm-docs container version tagging#3128
samsrabin merged 13 commits into
ESCOMP:b4b-devfrom
samsrabin:ctsm-docs-version-tagging

Conversation

@samsrabin

@samsrabin samsrabin commented May 13, 2025

Copy link
Copy Markdown
Member

Description of changes

The GitHub workflow that builds and pushes new versions of the ctsm-docs container doesn't include a tag with the version number. This PR fixes that. It also checks that the included version tag is formatted correctly and hasn't been used before.

Specific notes

Contributors other than yourself, if any: None

CTSM Issues Fixed:

Are answers expected to change (and if so in what way)? No

Any User Interface Changes (namelist or namelist defaults changes)? No

Does this create a need to change or add documentation? Did you do so? Yes, the README.md file next to the Dockerfile; yes.

Testing performed, if any: Tested at https://github.com/samsrabin/test-CTSM-docs-version-tagging:

@samsrabin samsrabin self-assigned this May 13, 2025
@samsrabin samsrabin added documentation additions or edits to user-facing documentation or its infrastructure devops Development Operations to improve development throughput, E.g., adding GitHub Workflows labels May 13, 2025
@samsrabin samsrabin changed the base branch from master to b4b-dev May 13, 2025 18:14
Comment thread .github/workflows/docker-image-build.yml
Comment thread .github/workflows/docker-image-build.yml
Comment thread doc/ctsm-docs_container/get_version.sh Outdated
@samsrabin samsrabin force-pushed the ctsm-docs-version-tagging branch from 757932a to dd730c2 Compare May 13, 2025 18:49
@samsrabin samsrabin force-pushed the ctsm-docs-version-tagging branch from 22f300b to fd6d7c9 Compare May 13, 2025 19:12
@samsrabin samsrabin changed the title [WIP] Fix ctsm-docs container version tagging Fix ctsm-docs container version tagging May 13, 2025
@samsrabin samsrabin added the PR status: awaiting review Work on this PR is paused while waiting for review. label May 13, 2025
Comment thread doc/ctsm-docs_container/Dockerfile
Comment thread .github/workflows/docker-image-build-publish.yml
Comment thread .github/workflows/docker-image-common.yml
Comment thread .github/workflows/docker-image-common.yml
@samsrabin samsrabin marked this pull request as ready for review May 13, 2025 21:55
@samsrabin samsrabin added the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label May 13, 2025
Comment thread .github/workflows/docker-image-common.yml
@samsrabin samsrabin moved this to In Progress in CTSM6 documentation May 14, 2025
@samsrabin samsrabin removed the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label May 15, 2025
@samsrabin samsrabin requested a review from ekluzek May 15, 2025 22:18
@ekluzek ekluzek removed the PR status: awaiting review Work on this PR is paused while waiting for review. label May 15, 2025

@ekluzek ekluzek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samsrabin and I went over this in depth. This is good work, and the changes make sense, and are needed for what happens.

This will be something that CTSM SE developers might need to work with on occasion and there's documentation on how to do the basic things. The whole package has complexity to it, but we likely won't need to modify it very often. I'm glad @samsrabin has developed expertise in this area, and we will undoubtably use that for other things as well.

@samsrabin samsrabin merged commit c7f47b6 into ESCOMP:b4b-dev May 16, 2025
7 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in CTSM6 documentation May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devops Development Operations to improve development throughput, E.g., adding GitHub Workflows documentation additions or edits to user-facing documentation or its infrastructure

Projects

No open projects

Development

Successfully merging this pull request may close these issues.

Increment docs container version

2 participants