ctsm5.3.042: Update FatesColdAllVars history output#3058
Conversation
FatesColdAllVars history ouptuFatesColdAllVars history output
90f62e7 to
a440381
Compare
|
Ideally we should have a fix in for NGEET/fates#700 in prior to this update as well. |
|
Per discussion at the ctsm-fates standup and fates software engineering meeting today, I'm going to coordinate this to be integrated with NGEET/fates#1252. To do:
|
…into fates-tests-allvars-update
FatesColdAllVars history outputFatesColdAllVars history output
|
To do:
Note: On second thought, I'm going to leave the new |
We don't currently have a PEM f10 test for seed dispersal. I believe we changed it for the 5x5_amazon
FatesColdAllVars history outputFatesColdAllVars history output
|
Izumi testing completed as well, but some of the baseline files were not available due to permission issues. I will retest these. Results: |
|
Note that the only diffs are in FATES tests, which are expected due to the fates tag updates to science and the NLCOMP diff due to #3063. Results: UPDATE: I realized there are two fates tests that didn't get checked against baseline due to permission restrictions in |
I realized that these are actually expected RUN failures and not problems with the permission, which is why the baselines are not available: CTSM/cime_config/testdefs/ExpectedTestFails.xml Lines 188 to 208 in e0104b9 @adrifoster I'll update the change log and this should be good to go. |
Description of changes
This PR updates the
fincl1list of nominally inactive FATES history output with recent additions to theFatesColdAllVarshistory output. Resolves #3052.Specific notes
This should be integrated after NGEET/fates#1338 has been merged into FATES
mainand the ctsm tag has been updated to a fates tag that is associated with said PR (or newer).This should be coordinated with NGEET/fates#1252 as that PR makes changes to the output names that would otherwise break the test.
#3063 has been merged into this PR as well as that PR is B4B and we would like to integrate it prior to NGEET/fates#1350.
Contributors other than yourself, if any:
CTSM Issues Fixed (include github issue #): #3052
Are answers expected to change (and if so in what way)?
FIELDLISTdiffs only forFatesColdAllVarsAny User Interface Changes (namelist or namelist defaults changes)? No
Does this create a need to change or add documentation? Did you do so? No
Testing performed, if any:
(List what testing you did to show your changes worked as expected)
(This can be manual testing or running of the different test suites)
(Documentation on system testing is here: https://github.com/ESCOMP/ctsm/wiki/System-Testing-Guide)
(aux_clm on derecho for intel/gnu and izumi for intel/gnu/nag/nvhpc is the standard for tags on master)
NOTE: Be sure to check your coding style against the standard
(https://github.com/ESCOMP/ctsm/wiki/CTSM-coding-guidelines) and review
the list of common problems to watch out for
(https://github.com/ESCOMP/CTSM/wiki/List-of-common-problems).