Skip to content

ctsm5.3.042: Update FatesColdAllVars history output#3058

Merged
adrifoster merged 17 commits into
ESCOMP:masterfrom
glemieux:fates-tests-allvars-update
May 9, 2025
Merged

ctsm5.3.042: Update FatesColdAllVars history output#3058
adrifoster merged 17 commits into
ESCOMP:masterfrom
glemieux:fates-tests-allvars-update

Conversation

@glemieux
Copy link
Copy Markdown
Contributor

@glemieux glemieux commented Apr 9, 2025

Description of changes

This PR updates the fincl1 list of nominally inactive FATES history output with recent additions to the FatesColdAllVars history output. Resolves #3052.

Specific notes

This should be integrated after NGEET/fates#1338 has been merged into FATES main and the ctsm tag has been updated to a fates tag that is associated with said PR (or newer).

This should be coordinated with NGEET/fates#1252 as that PR makes changes to the output names that would otherwise break the test.

#3063 has been merged into this PR as well as that PR is B4B and we would like to integrate it prior to NGEET/fates#1350.

Contributors other than yourself, if any:

CTSM Issues Fixed (include github issue #): #3052

Are answers expected to change (and if so in what way)? FIELDLIST diffs only for FatesColdAllVars

Any User Interface Changes (namelist or namelist defaults changes)? No

Does this create a need to change or add documentation? Did you do so? No

Testing performed, if any:
(List what testing you did to show your changes worked as expected)
(This can be manual testing or running of the different test suites)
(Documentation on system testing is here: https://github.com/ESCOMP/ctsm/wiki/System-Testing-Guide)
(aux_clm on derecho for intel/gnu and izumi for intel/gnu/nag/nvhpc is the standard for tags on master)

NOTE: Be sure to check your coding style against the standard
(https://github.com/ESCOMP/ctsm/wiki/CTSM-coding-guidelines) and review
the list of common problems to watch out for
(https://github.com/ESCOMP/CTSM/wiki/List-of-common-problems).

@glemieux glemieux added FATES A change needed for FATES that doesn't require a FATES API update. test: fates Pass fates test suite before merging labels Apr 9, 2025
@glemieux glemieux changed the title Update FatesColdAllVars history ouptu Update FatesColdAllVars history output Apr 9, 2025
@glemieux glemieux self-assigned this Apr 9, 2025
@glemieux glemieux mentioned this pull request Apr 9, 2025
4 tasks
@glemieux glemieux requested review from ekluzek and rgknox April 11, 2025 18:56
@glemieux glemieux moved this to In progress - master/b4b-dev in CTSM: Upcoming tags Apr 11, 2025
@ekluzek ekluzek moved this from In progress - master to In progress - b4b-dev in CTSM: Upcoming tags Apr 21, 2025
@glemieux glemieux changed the base branch from master to b4b-dev April 22, 2025 20:42
@glemieux glemieux force-pushed the fates-tests-allvars-update branch from 90f62e7 to a440381 Compare April 22, 2025 21:46
@glemieux glemieux added the b4b bit-for-bit label Apr 22, 2025
@glemieux glemieux moved this from Todo to Final Testing in FATES Pull Request Planning and Status Apr 23, 2025
@glemieux glemieux moved this from In progress - b4b-dev to In progress - master in CTSM: Upcoming tags Apr 23, 2025
@glemieux glemieux moved this from Final Testing to Stuck in FATES Pull Request Planning and Status Apr 23, 2025
@glemieux
Copy link
Copy Markdown
Contributor Author

Ideally we should have a fix in for NGEET/fates#700 in prior to this update as well.

@glemieux glemieux moved this from Stuck to Under Review in FATES Pull Request Planning and Status Apr 23, 2025
@glemieux glemieux moved this from Under Review to Hold in FATES Pull Request Planning and Status Apr 23, 2025
@glemieux glemieux moved this from In progress - master to In progress - b4b-dev in CTSM: Upcoming tags Apr 23, 2025
@ekluzek ekluzek moved this from In progress - b4b-dev to In progress - master in CTSM: Upcoming tags Apr 28, 2025
@glemieux glemieux moved this from Hold to Final Testing in FATES Pull Request Planning and Status Apr 28, 2025
@glemieux
Copy link
Copy Markdown
Contributor Author

glemieux commented Apr 28, 2025

Per discussion at the ctsm-fates standup and fates software engineering meeting today, I'm going to coordinate this to be integrated with NGEET/fates#1252.

To do:

@glemieux glemieux changed the base branch from b4b-dev to master April 28, 2025 22:37
@glemieux glemieux removed b4b bit-for-bit FATES A change needed for FATES that doesn't require a FATES API update. labels Apr 28, 2025
@ekluzek ekluzek changed the title Update FatesColdAllVars history output ctsm5.3.043: Update FatesColdAllVars history output Apr 29, 2025
@glemieux
Copy link
Copy Markdown
Contributor Author

glemieux commented Apr 29, 2025

To do:

Note: On second thought, I'm going to leave the new FatesColdElecTranJB test in the list as it runs. There is just nothing on the FATES end to receive it yet. As a result we'll see a DIFF once we integrate NGEET/fates#1350.

We don't currently have a PEM f10 test for seed dispersal.  I believe we
changed it for the 5x5_amazon
@glemieux glemieux linked an issue May 2, 2025 that may be closed by this pull request
@glemieux glemieux moved this from Final Testing to Hold in FATES Pull Request Planning and Status May 5, 2025
@glemieux glemieux moved this from Final Testing to Hold in FATES Pull Request Planning and Status May 5, 2025
@ekluzek ekluzek changed the title ctsm5.3.043: Update FatesColdAllVars history output ctsm5.3.042: Update FatesColdAllVars history output May 7, 2025
@glemieux
Copy link
Copy Markdown
Contributor Author

glemieux commented May 8, 2025

aux_clm regression testing on derecho against ctsm5.3.041 is complete. All expected tests are B4B. The only differences are in the fates tests and are expected due to updating the fates tag. The fates NLCOMP differences are expected as well per #3063.

Izumi testing completed as well, but some of the baseline files were not available due to permission issues. I will retest these.

Results: /glade/u/home/glemieux/scratch/ctsm-tests/tests_pr3085-auxclm

@glemieux
Copy link
Copy Markdown
Contributor Author

glemieux commented May 8, 2025

aux_clm regression testing in izumi against ctsm5.3.040 is complete and all expected tests are b4b. Per the CTSM SE meeting today, it was recommended to test against this previous tag as the ctsm5.3.041 tag has some tests with permission restrictions. Since 041 is the b4b-dev merge, there should be consistency with 040.

Note that the only diffs are in FATES tests, which are expected due to the fates tag updates to science and the NLCOMP diff due to #3063.

Results: /scratch/cluster/glemieux/ctsm-tests/tests_0508-100725iz

UPDATE: I realized there are two fates tests that didn't get checked against baseline due to permission restrictions in ctsm5.3.040:

SMS_Ld10_D_Mmpi-serial.CLM_USRDAT.I1PtClm60Fates.izumi_nag.clm-FatesFireLightningPopDens--clm-NEON-FATES-NIWO
SMS_Ld10_D_Mmpi-serial.CLM_USRDAT.I1PtClm60Fates.izumi_nag.clm-FatesPRISM--clm-NEON-FATES-YELL

@glemieux
Copy link
Copy Markdown
Contributor Author

glemieux commented May 8, 2025

UPDATE: I realized there are two fates tests that didn't get checked against baseline due to permission restrictions in ctsm5.3.040:

SMS_Ld10_D_Mmpi-serial.CLM_USRDAT.I1PtClm60Fates.izumi_nag.clm-FatesFireLightningPopDens--clm-NEON-FATES-NIWO
SMS_Ld10_D_Mmpi-serial.CLM_USRDAT.I1PtClm60Fates.izumi_nag.clm-FatesPRISM--clm-NEON-FATES-YELL

I realized that these are actually expected RUN failures and not problems with the permission, which is why the baselines are not available:

<test name="SMS_Ld10_D_Mmpi-serial.CLM_USRDAT.I1PtClm60Fates.izumi_nag.clm-FatesFireLightningPopDens--clm-NEON-FATES-NIWO">
<phase name="SHAREDLIB_BUILD">
<status>FAIL</status>
<issue>#2310</issue>
</phase>
<phase name="RUN">
<status>FAIL</status>
<issue>#2310</issue>
</phase>
</test>
<test name="SMS_Ld10_D_Mmpi-serial.CLM_USRDAT.I1PtClm60Fates.izumi_nag.clm-FatesPRISM--clm-NEON-FATES-YELL">
<phase name="SHAREDLIB_BUILD">
<status>FAIL</status>
<issue>#2310</issue>
</phase>
<phase name="RUN">
<status>FAIL</status>
<issue>#2310</issue>
</phase>
</test>

@adrifoster I'll update the change log and this should be good to go.

@adrifoster adrifoster merged commit 6bba868 into ESCOMP:master May 9, 2025
3 checks passed
@github-project-automation github-project-automation Bot moved this from Hold to Ready to Integrate in FATES Pull Request Planning and Status May 9, 2025
@github-project-automation github-project-automation Bot moved this from In progress - master to Done (non release/external) in CTSM: Upcoming tags May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FATES A change needed for FATES that doesn't require a FATES API update. test: fates Pass fates test suite before merging

Projects

Status: Done (non release/external)

Development

Successfully merging this pull request may close these issues.

Update FatesColdAllVars history output with recent additions NEON-FATES-NIWO test in aux_clm fails RUN

4 participants