update flds_exchange_nems for wave coupling changes#324
Merged
Conversation
* updates CMEPS with latests changes from ESCOMP, including - xgrid capablility (cesm only) - refactored accumulation field bundles - cleaned up med.F90 for mesh creation - refactored mediatory history functionality
* moved files into ufs * implemented different interface for ufs flux_atmocn_mod * add compile fixes for ufs * removed reference to util and replaced with ufs * clean up of Makefile * removed references to use of med_kind_mod and introduced ufs_kind_mod * removed unneeded files needed by ufs * Optional tiled history files for ATM (ESCOMP#257)
…oupling through CMEPS (NOAA-EMC#61) * Add Wave slow loop coupling and Field Exchanges for waves in nems * Updates CMEPS for dynamic allocation in med_internalstate
…-EMC#65) * Refactor source and destination masking * Refactor esmFieldsExchange with the advertise and initialize phases * Implement a check that each component pair for a field advertise is present. * Permit coupling of ATM-WAV with the CMEPS mediator.
* add new flux computation for UFS model and add new coupling mode for exchange grid implementation * fix area field for new flux algorithm * send fluxes to atmospheric model * initial implementation for sending fluxes to UFS ATM * update CCPP host model * fix latent and sensible heat fluxes and clean code * add new coupling mode for side by side flux comparison * fix CCPP host model for latent and sensible heat fluxes * fix aoflux calculation on agrid and add missing error checks * add option to write meshes and update code that retrieve area information from xgrid * update ccpp host based on recent changes in ccpp framework * fix for providing cell area to CCPP host model * make ccpp physics options configurable * Refactor nems field exchange; set default masks for mapping in med_internalstate (ESCOMP#279) Refactors esmFldsExchange_nems.F90 to use separate advertise and initialize phases and to check that a component is present before advertising a field to or from that component. Implements default src and dst mask values in place of the code currently in med_map_mod.F90. Fixes NOAA-EMC#63 and NOAA-EMC#64. * use mesh file instead of grid name (ESCOMP#285) This was done so that vertical component used in grid name does not affect tests. Co-authored-by: Dom Heinzeller <climbfuji@ymail.com> Co-authored-by: Francis Vitt <fvitt@ucar.edu> Co-authored-by: Courtney Peverley <courtneyp@izumi.cgd.ucar.edu> Co-authored-by: Jim Edwards <jedwards@ucar.edu> Co-authored-by: mvertens <mvertens@users.noreply.github.com> Co-authored-by: Denise Worthen <denise.worthen@noaa.gov> Co-authored-by: Mariana Vertenstein <mvertens@ucar.edu> Co-authored-by: Ufuk Turuncoglu <ufuk.turuncoglu@noaa.gov>
* add bilnr_nstod mapping between ocn/ice/waves
* add wave-ice coupling fields
* add support for external land component * update exchange fields for nems to include land * remove physparam.f in MED_typedefs.meta Ufuk Turuncoglu <ufuk.turuncoglu@noaa.gov>
jedwards4b
approved these changes
Dec 1, 2022
uturuncoglu
approved these changes
Dec 1, 2022
Collaborator
|
@DeniseWorthen Okay. That sounds fine. Since all the tests are passing, I think it would be fine. Thanks again. |
Collaborator
Author
|
@jedwards4b Could you go ahead and merge this PR? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Changes mapping type for UFS between wave-ice-ocn to be bilinear with nstod fill.
Adds optional wave-ice coupling for UFS.
Minor trailing whitespace cleanup.
Testing performed
Testing performed if application target is CESM:
Testing performed if application target is UFS-coupled:
Testing performed if application target is UFS-HAFS:
Hashes used for testing: