initialize drydep_nflds to 0#273
Merged
Merged
Conversation
mvertens
approved these changes
Mar 3, 2022
Collaborator
|
@peverwhee - can you please summarize what test(s) failed and needed this fix. It would be good to get that in the issue as well. Thanks for finding this and fixing it. |
Collaborator
Author
Good call. Added to the description. |
|
Can this get merged? If not, what else needs to be done? |
jedwards4b
approved these changes
Mar 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
initialize drydep_nflds to 0 in seq_drydep_readnl.
Issue found when running CAM test ERP_Ln9_Vnuopc.ne5pg3_ne5pg3_mg37.QPC6.izumi_nag.cam-outfrq9s_clubbmf with the nuopc driver. Got the following error (and preceding log message):
Specific notes
Contributors other than yourself, if any: N/A
CMEPS Issues Fixed (include github issue #): resolves #272
Are changes expected to change answers? (specify if bfb, different at roundoff, more substantial) No answer changes.
Any User Interface Changes (namelist or namelist defaults changes)? no user interface changes
Testing performed
Testing performed if application target is CESM:
Testing performed if application target is UFS-coupled:
Testing performed if application target is UFS-HAFS:
Hashes used for testing: