fix aoflux calculation on agrid and add missing error checks#271
Merged
Conversation
Collaborator
Author
|
@mvertens I did not test it under CESM yet. I'll also run at least one S2S configuration (i.e. cpld_control) to see what happens. I am not expecting any issue but it would be nice to be in safe side. |
Collaborator
Author
|
@mvertens @DeniseWorthen I tested it under UFS by running |
DeniseWorthen
approved these changes
Mar 2, 2022
mvertens
approved these changes
Mar 2, 2022
Collaborator
|
@uturuncoglu - thank you for fixing this. |
korsbakken
pushed a commit
to korsbakken/CMEPS
that referenced
this pull request
Oct 23, 2025
…t_data_list make the amount of data required to download minimal for testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR aims to fix atmosphere-ocean flux calculation on agrid. It also adds couple of missing check for the ESMF calls.
Specific notes
Contributors other than yourself, if any:
CMEPS Issues Fixed (include github issue #): #270
Are changes expected to change answers? (specify if bfb, different at roundoff, more substantial)
No, bfb
Any User Interface Changes (namelist or namelist defaults changes)?
No
Testing performed
Testing performed if application target is CESM:
Testing performed if application target is UFS-coupled:
Testing performed if application target is UFS-HAFS:
Hashes used for testing: