Bug fixes for CESM 1850 mct/nuopc validation#195
Conversation
|
@uturuncoglu @DeniseWorthen - this PR should not effect the UFS configuration. @jedwards4b is on vacation - so if you both could review and hopefully accept this - I will merge. |
|
@DeniseWorthen - are you okay with this PR? If so can you please sign off on it. |
DeniseWorthen
left a comment
DeniseWorthen
left a comment
There was a problem hiding this comment.
No impact to ufs-weather.
jedwards4b
left a comment
jedwards4b
left a comment
There was a problem hiding this comment.
I removed a debug print statement.
|
@mvertens why did the change you make fix a memory leak? Was it an issue associated with a compiler bug or did you find a bug in cmeps? |
|
@jedwards4b - I found a bug in cmeps and included a fix in this PR.
…On Tue, Jun 1, 2021 at 7:55 AM jedwards4b ***@***.***> wrote:
@mvertens <https://github.com/mvertens> why did the change you make fix a
memory leak? Was it an issue associated with a compiler bug or did you find
a bug in cmeps?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#195 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB4XCEZIZQ6MKAFJYLLBESLTQTRFJANCNFSM45HOY26Q>
.
--
Mariana Vertenstein
CESM Software Engineering Group Head
National Center for Atmospheric Research
Boulder, Colorado
Office 303-497-1349
Email: ***@***.***
|
|
@mvertens can you point out the bug fix? It's hard to spot given all of the format changes in med_diag_mod.F90 |
|
@jedwards4b - its the addition of 2 new deallocate statements (for afrac and sfrac). Also - its removing the embedded routines with multiple level of contains and making them separate routines as part of this. |
|
great, thanks for clarifying |
Shr file set log unit ### Description of changes depricate shr_file_getLogUnit, add shr_log_getLogUnit ### Specific notes require share1.0.14 for cesm Contributors other than yourself, if any: CDEPS Issues Fixed (include github issue #): Are there dependencies on other component PRs (if so list): Are changes expected to change answers (bfb, different to roundoff, more substantial): Any User Interface Changes (namelist or namelist defaults changes): Testing performed (e.g. aux_cdeps, CESM prealpha, etc): CESM prealpha cheyenne intel compared to cesm2.3.alpha10d - all consistent with baselines. Hashes used for testing:
4 participants
Description of changes
Bug fixes for CESM 1850 mct/nuopc validation - including memory leak in med_diag_mod.F90.
Specific notes
These are changes needed to the budgets and run sequence needed that were needed to fix problems in the B1850 mct/nuopc validation.
Contributors other than yourself, if any: @jedwards4b
CMEPS Issues Fixed: #190 #197
Are changes expected to change answers?
Any User Interface Changes (namelist or namelist defaults changes)?
Testing performed if application target is CESM:(either UFS-S2S or CESM testing is required):
5 year B1850 1 year simulation was run
Hashes used for testing: