Skip to content

fixes to land ice runoff in budget table#180

Merged
mvertens merged 1 commit into
ESCOMP:masterfrom
mvertens:feature/fix_lnd_ice_runoff
May 6, 2021
Merged

fixes to land ice runoff in budget table#180
mvertens merged 1 commit into
ESCOMP:masterfrom
mvertens:feature/fix_lnd_ice_runoff

Conversation

@mvertens
Copy link
Copy Markdown
Collaborator

@mvertens mvertens commented May 5, 2021

Description of changes

This fixes the budget table to have the correct land ice runoff value and balance the runoff sent to the ocean.

Specific notes

This PR does not affect any UFS configuration, since the UFS does not use the budget tables at this point.

Contributors other than yourself, if any:

CMEPS Issues Fixed:
Fixes #179

Are changes expected to change answers?

  • bit for bit
  • different at roundoff level
  • more substantial

Any User Interface Changes (namelist or namelist defaults changes)?

  • Yes
  • No

Testing performed if application target is CESM:(either UFS-S2S or CESM testing is required):
Ran a B1850 f19_g17 case for 3 months and verified that the budget table looked correct with this term

Testing performed if application target is UFS-coupled:

  • (recommended) UFS-coupled testing
    • description:
    • details (e.g. failed tests):

Hashes used for testing:

@mvertens mvertens removed the request for review from DeniseWorthen May 6, 2021 01:35
@mvertens
Copy link
Copy Markdown
Collaborator Author

mvertens commented May 6, 2021

@DeniseWorthen - I have taken you off as a reviewer since we communicated in email that there was no impact for UFS with this PR.

@mvertens mvertens merged commit 81e1418 into ESCOMP:master May 6, 2021
@mvertens mvertens self-assigned this May 6, 2021
@mvertens mvertens deleted the feature/fix_lnd_ice_runoff branch September 10, 2021 18:38
korsbakken pushed a commit to korsbakken/CMEPS that referenced this pull request Oct 23, 2025
…drof, dwav (ESCOMP#180)

* add skip_restart functionality to all components that can use it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

budget table does not have entry for lnd ice runoff

2 participants