Skip to content

some corrections to the med diag calculations#177

Merged
jedwards4b merged 2 commits into
ESCOMP:masterfrom
jedwards4b:med_diag_corrections
Apr 28, 2021
Merged

some corrections to the med diag calculations#177
jedwards4b merged 2 commits into
ESCOMP:masterfrom
jedwards4b:med_diag_corrections

Conversation

@jedwards4b
Copy link
Copy Markdown
Collaborator

@jedwards4b jedwards4b commented Apr 27, 2021

Description of changes

Correct the accumulation of budget diagnostics

Specific notes

Contributors other than yourself, if any:

CMEPS Issues Fixed (include github issue #):

Are changes expected to change answers?

  • bit for bit
  • different at roundoff level
  • more substantial

Any User Interface Changes (namelist or namelist defaults changes)?

  • Yes
  • No

Testing performed if application target is CESM:(either UFS-S2S or CESM testing is required):

  • (recommended) CIME_DRIVER=nuopc scripts_regression_tests.py
    • machines: cheyenne / intel
    • details (e.g. failed tests):
  • (recommended) CESM testlist_drv.xml
    • machines and compilers: cheyenne / intel
    • details (e.g. failed tests):
  • (optional) CESM prealpha test
    • machines and compilers
    • details (e.g. failed tests):
  • (other) please described in detail
    • machines and compilers
    • details (e.g. failed tests):

Testing performed if application target is UFS-coupled:

  • (recommended) UFS-coupled testing
    • description:
    • details (e.g. failed tests):

Testing performed if application target is UFS-HAFS:

  • (recommended) UFS-HAFS testing
    • description:
    • details (e.g. failed tests):

Hashes used for testing:

  • CESM:
  • UFS-coupled, then umbrella repostiory to check out and associated hash:
    • repository to check out:
    • branch:
    • hash:
  • UFS-HAFS, then umbrella repostiory to check out and associated hash:
    • repository to check out:
    • branch:
    • hash:

@jedwards4b jedwards4b requested a review from mvertens April 27, 2021 20:55
@jedwards4b jedwards4b self-assigned this Apr 27, 2021
@jedwards4b jedwards4b marked this pull request as draft April 27, 2021 21:53
@jedwards4b jedwards4b marked this pull request as ready for review April 28, 2021 13:03
@jedwards4b jedwards4b merged commit c0c2001 into ESCOMP:master Apr 28, 2021
@jedwards4b jedwards4b deleted the med_diag_corrections branch April 28, 2021 13:03
korsbakken pushed a commit to korsbakken/CMEPS that referenced this pull request Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants