Clean up esmFldsExchange_hafs_mod.F90 file

[danrosen25]

Description of changes

This change splits esmFldsExchange_hafs_mod.F90 into two subroutines for maintenance purposes. The interface into esmFldsExchange_hafs has not changed but will call into one of the following subroutines.
esmFldsExchange_hafs_advt (advertise): advertise import and export fields
esmFldsExchange_hafs_init (initialize): establish field mapping and merges after field connections establish

Specific notes

Contributors other than yourself, if any: none

CMEPS Issues Fixed (include github issue #): none

Are changes expected to change answers?

• bit for bit
• different at roundoff level
• more substantial

Any User Interface Changes (namelist or namelist defaults changes)?

• Yes
• No

Testing performed if application target is CESM:(either UFS-S2S or CESM testing is required):

• (required) CIME_DRIVER=nuopc scripts_regression_tests.py
  • machines:
  • details (e.g. failed tests):
• (required) CESM testlist_drv.xml
  • machines and compilers: Cheyenne / Intel and MPT combination shipped with the CESM app
  • details (e.g. failed tests):
    Test Command:

qcmd -l walltime=4:00:00 -- ./create_test --xml-testlist ../src/drivers/nuopc/cime_config/testdefs/testlist_drv.xml --xml-machine cheyenne --xml-category nuopc --compare oct14 --baseline-root /glade/p/cesmdata/cseg/cmeps_baselines

    FAIL ERS_Vnuopc_Ln9_N3.f19_g17_rx1.A.cheyenne_intel TPUTCOMP Error: Computation time increase > 25 pct from baseline
    FAIL SMS_Vnuopc_Ld1_N3.f19_g17_rx1.A.cheyenne_intel TPUTCOMP Error: Computation time increase > 25 pct from baseline
    FAIL SMS_Vnuopc_Ld5.T62_t061.CMOM.cheyenne_intel MEMCOMP Error: Memory usage increase > 10% from baseline

i also tested with UFS HAFS application and it passed.

• (optional) CESM prealpha test
  • machines and compilers
  • details (e.g. failed tests):

Testing performed if application target is UFS-S2S:

• (required) UFS-S2S testing
  • description:
  • details (e.g. failed tests):

Hashes used for testing:

• CESM:
  • repository to check out: https://github.com/ESCOMP/CESM.git
  • branch: nuopc_dev
  • hash: 54d5c92
• UFS-S2S, then umbrella repostiory to check out and associated hash:
  • repository to check out:
  • branch:
  • hash:

[uturuncoglu]

@mvertens i am testing this PR with CESM and also HAFS app to be sure and let you know.

[DeniseWorthen]

This looks harmless for nems side of things. But I'm curious as to what the motivation was to do this.

[uturuncoglu]

@DeniseWorthen I think the best person to answer this is @danrosen25

[danrosen25]

Hi @DeniseWorthen
I cleaned up the the hafs configuration in preparation to support both CDEPS-ATM -> HYCOM and UFSATM <-> HYCOM configurations. The two configurations require different field exchanges/mappings/merges.

[DeniseWorthen]

This has no impact on nems (I built and ran a single RT).

[uturuncoglu]

@mvertens if you approve this PR, I could merge it. I tested with both CESM and UFS HAFS and everything seems fine.

[mvertens]

I have just approved the PR.

…

On Fri, Oct 16, 2020 at 9:26 AM Ufuk Turunçoğlu ***@***.***> wrote: @mvertens <https://github.com/mvertens> if you approve this PR, I could merge it. I tested with both CESM and UFS HAFS and everything seems fine. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#114 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB4XCE7MAGT6I3CWS4PLULLSLBQ2JANCNFSM4SP2NNUA> .

-- Mariana Vertenstein CESM Software Engineering Group Head National Center for Atmospheric Research Boulder, Colorado Office 303-497-1349 Email: mvertens@ucar.edu