Advertise import fields even with noevolve#86
Merged
Conversation
This is needed for the MED -> GLC mapping to work
Member
Author
|
It turns out that these changes require the above CMEPS changes. |
Katetc
approved these changes
Apr 16, 2024
Contributor
|
Since the CMEPS changes have been merged and tagged, I am going to bring in this PR and then open one that updates CISM-wrapper Externals as well. I will make the cismwrap_2_1_100 tag including both of these PRs so it builds and runs correctly. |
Contributor
|
@Katetc — That sounds great. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed for the MED -> GLC mapping to work in ESCOMP/CMEPS#442. So the changes here and the changes in that CMEPS PR are inter-dependent (though it might work to bring in these CISM-wrapper changes before those CMEPS changes; I haven't tested that).
I have tested this by running aux_glc on derecho (intel & gnu) on this branch along with the changes from ESCOMP/CMEPS#442 cherry-picked onto cmeps0.14.43. Failures were as expected:
(The NCK test fails on master, too.) I confirmed that the diffs are as expected.