Skip to content

Advertise import fields even with noevolve#86

Merged
Katetc merged 1 commit into
ESCOMP:masterfrom
billsacks:cism_noevolve_med2glc
Apr 17, 2024
Merged

Advertise import fields even with noevolve#86
Katetc merged 1 commit into
ESCOMP:masterfrom
billsacks:cism_noevolve_med2glc

Conversation

@billsacks
Copy link
Copy Markdown
Member

This is needed for the MED -> GLC mapping to work in ESCOMP/CMEPS#442. So the changes here and the changes in that CMEPS PR are inter-dependent (though it might work to bring in these CISM-wrapper changes before those CMEPS changes; I haven't tested that).

I have tested this by running aux_glc on derecho (intel & gnu) on this branch along with the changes from ESCOMP/CMEPS#442 cherry-picked onto cmeps0.14.43. Failures were as expected:

    FAIL ERS_D_Ly3.f09_g17_gris4.T1850Gg.derecho_intel.cism-noevolve NLCOMP
    FAIL ERS_D_Ly3.f09_g17_gris4.T1850Gg.derecho_intel.cism-noevolve BASELINE /glade/derecho/scratch/sacks/aux_glc_240301164745/baselines: DIFF
    FAIL NCK_Ly3.f09_g17_gris20.T1850Gg.derecho_gnu COMPARE_base_multiinst
    FAIL SMS_Lm13.f10_f10_mg37.I1850Clm50SpG.derecho_intel.cism-noevolve NLCOMP
    FAIL SMS_Lm13.f10_f10_mg37.I1850Clm50SpG.derecho_intel.cism-noevolve BASELINE /glade/derecho/scratch/sacks/aux_glc_240301164745/baselines: DIFF

(The NCK test fails on master, too.) I confirmed that the diffs are as expected.

This is needed for the MED -> GLC mapping to work
@billsacks
Copy link
Copy Markdown
Member Author

It turns out that these changes require the above CMEPS changes.

@Katetc
Copy link
Copy Markdown
Contributor

Katetc commented Apr 17, 2024

Since the CMEPS changes have been merged and tagged, I am going to bring in this PR and then open one that updates CISM-wrapper Externals as well. I will make the cismwrap_2_1_100 tag including both of these PRs so it builds and runs correctly.

@Katetc Katetc merged commit 1e8ef7e into ESCOMP:master Apr 17, 2024
@whlipscomb
Copy link
Copy Markdown
Contributor

@Katetc — That sounds great. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants