Skip to content

Fix align year#92

Merged
jedwards4b merged 7 commits into
ESCOMP:masterfrom
ekluzek:fixalignyear
May 14, 2021
Merged

Fix align year#92
jedwards4b merged 7 commits into
ESCOMP:masterfrom
ekluzek:fixalignyear

Conversation

@ekluzek
Copy link
Copy Markdown
Collaborator

@ekluzek ekluzek commented May 13, 2021

Description of changes

Fix the align year issue. Fix a total of three issues.

Specific notes

Contributors other than yourself, if any:

CMEPS Issues Fixed (include github issue #):
Fixes #86
Fixes #89
Fixes #91

Are there dependencies on other component PRs: No

  • CIME (list)
  • CMEPS (list)

Are changes expected to change answers?

  • [ x] bit for bit
  • different at roundoff level
  • more substantial
    Technically tests with the 1PT sites will be different because the start date is different.

Any User Interface Changes (namelist or namelist defaults changes)?

  • Yes
  • [ x] No

The one caveat is that now $DATM_YR is enabled to work for the 1PT sites

Testing performed:

  • [ x] (required) aux_cdeps
    • machines and compilers: cheyenne_intel
    • failed tests: Since I tested in a CTSM checkout the DLND test fails as expected, but as no changes to dlnd this shouldn't matter:
      SMS_Vnuopc_Ld3.f09_f09_mg17.1850_SATM_DLND%SCPL_SICE_SOCN_SROF_SGLC_SWAV.cheyenne_intel

Hashes used for testing:

@ekluzek ekluzek requested a review from jedwards4b May 13, 2021 22:39
@ekluzek ekluzek added bug Something isn't working and removed bug Something isn't working labels May 13, 2021
@ekluzek
Copy link
Copy Markdown
Collaborator Author

ekluzek commented May 13, 2021

@jedwards4b and @mvertens let me know if there's anything else you want me to change here. I'll need this in a tag for CTSM. Thanks.

@jedwards4b jedwards4b merged commit 35de2cb into ESCOMP:master May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants