this compset should not produce an ocn stream file#71
Merged
Conversation
mvertens
approved these changes
Apr 28, 2021
uturuncoglu
approved these changes
Apr 28, 2021
Contributor
Author
|
This fix was incorrect, it causes issue #83 and causes SMS_Vnuopc.f19_f19_mg17.ADSOMAQP.cheyenne_intel to fail. I will submit a new PR to undo it. |
12 tasks
jedwards4b
added a commit
that referenced
this pull request
May 3, 2021
### Description of changes Add back stream files for docn_mode=='som_aquap' PR #71 broke several compsets. ### Specific notes Contributors other than yourself, if any: CMEPS Issues Fixed (include github issue #): Are there dependencies on other component PRs - [ ] CIME (list) - [ ] CMEPS (list) Are changes expected to change answers? - [X] bit for bit - [ ] different at roundoff level - [ ] more substantial Any User Interface Changes (namelist or namelist defaults changes)? - [ ] Yes - [X] No Testing performed: - [X] (required) aux_cdeps - machines and compilers: cheyenne, intel - details (e.g. failed tests): ALL pass also tested with PR#73 merged. - [ ] (optional) CESM prealpha test - machines and compilers - details (e.g. failed tests): Hashes used for testing: - [X] CIME - repository to check out: https://github.com/ESCOMP/CESM.git - branch: master - hash: 296aeaf4a - [X] CMEPS - repository to check out: https://github.com/ESCOMP/CESM.git - branch: master - hash:c0c2001 - [ ] CESM - repository to check out: https://github.com/ESCOMP/CESM.git - branch: - hash:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
add docn_mode som_aquap to those that do not produce a stream file.
Specific notes
Contributors other than yourself, if any:
CDEPS Issues Fixed (include github issue #): #70
Are there dependencies on other component PRs
Are changes expected to change answers?
Any User Interface Changes (namelist or namelist defaults changes)?
Testing performed:
Hashes used for testing: