Remove local copy of FindESMF.cmake and rename esmf target to ESMF::ESMF#347
Closed
NickSzapiro-NOAA wants to merge 15 commits into
Closed
Remove local copy of FindESMF.cmake and rename esmf target to ESMF::ESMF#347NickSzapiro-NOAA wants to merge 15 commits into
NickSzapiro-NOAA wants to merge 15 commits into
Conversation
Contributor
Author
|
@jedwards4b I'm not sure what ESCOMP/CDEPS would like with this. There is also a similar PR for EMC/CMEPS. |
github actions should set ESMF_ROOT to point to the install path of the esmf library
Contributor
Author
|
Closing as not needed or used in ufs-weather-model |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
As part of ufs-weather-model, a PR was opened to EMC/CDEPS to remove local copy of FindESMF.cmake and rename esmf target to ESMF::ESMF (NOAA-EMC#73). ufs-weather-model would then use the FindESMF.cmake module provided by the ESMF library.
The idea is to find FindESMF in esmf_ROOT and get rid of all local copies of FindESMF.cmake in sub-components to help with issues like ufs-community/ufs-weather-model#2399
Does this work for the broader ESCOMP/CDEPS or maybe other changes are needed?
Specific notes
Contributors other than yourself, if any: Dusan Jovic
CDEPS Issues Fixed (include github issue #):
Are there dependencies on other component PRs (if so list):
Are changes expected to change answers (bfb, different to roundoff, more substantial): bfb
Any User Interface Changes (namelist or namelist defaults changes):
Testing performed (e.g. aux_cdeps, CESM prealpha, etc): Currently only tested in ufs-weather-model
Hashes used for testing: