Skip to content

Allow anomaly forcings with any DATM#340

Merged
jedwards4b merged 1 commit into
ESCOMP:mainfrom
samsrabin:ssp-anomalies-any-datm
Jun 2, 2025
Merged

Allow anomaly forcings with any DATM#340
jedwards4b merged 1 commit into
ESCOMP:mainfrom
samsrabin:ssp-anomalies-any-datm

Conversation

@samsrabin
Copy link
Copy Markdown
Member

@samsrabin samsrabin commented Jun 1, 2025

Description of changes

Removes check that datm_mode be GSWP3v1.

Specific notes

Contributors other than yourself, if any: None

CDEPS Issues Fixed:

Are there dependencies on other component PRs (if so list): No

Are changes expected to change answers (bfb, different to roundoff, more substantial): No

Any User Interface Changes (namelist or namelist defaults changes): No

Testing performed (e.g. aux_cdeps, CESM prealpha, etc):

  • aux_cdeps tests all pass compared to cdeps1.0.74

Hashes used for testing: 0a59658

@samsrabin
Copy link
Copy Markdown
Member Author

@ekluzek Just putting something in your inbox to ping about getting this reviewd.

Copy link
Copy Markdown
Collaborator

@ekluzek ekluzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes a problem that came in because I had misconstrued how the anomaly forcing works for SSP future scenarios. So it removes a check that shouldn't be there. And as such is a really simple change.

@ekluzek ekluzek added CESM Only answers are bfb Responsibility: CTSM Responsibility to manage and accomplish this issue is the CTSM Software group labels Jun 2, 2025
@ekluzek
Copy link
Copy Markdown
Collaborator

ekluzek commented Jun 2, 2025

@jedwards4b or @billsacks @fischer-ncar this has been tested on Derecho over the weekend before the shutdown. And it's really simple. And it's up to date with the latest CDEPS tag.

Could this be merged to main and made into a tag right away? Thanks

@jedwards4b jedwards4b merged commit 472264c into ESCOMP:main Jun 2, 2025
1 check passed
@samsrabin
Copy link
Copy Markdown
Member Author

Thanks @jedwards4b!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

answers are bfb CESM Only Responsibility: CTSM Responsibility to manage and accomplish this issue is the CTSM Software group

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow anomaly forcings with any datm

3 participants