shr_log_error and return up stack

[jedwards4b]

Description of changes

replace shr_sys_abort with shr_log_error and return up the call tree with an error code.

Specific notes

After discussion we decided to implement the write to both logs, but also return up the call tree rather than abort with a stack. However some routines do not have a return code variable and will need further work to comply.
CDEPS Issues Fixed (include github issue #):

Are there dependencies on other component PRs (if so list):

Are changes expected to change answers (bfb, different to roundoff, more substantial):

Any User Interface Changes (namelist or namelist defaults changes):

Testing performed (e.g. aux_cdeps, CESM prealpha, etc):

Hashes used for testing:

[DeniseWorthen]

I needed to add

diff --git a/streams/dshr_stream_mod.F90 b/streams/dshr_stream_mod.F90
index 691722e1..4dfff9ef 100644
--- a/streams/dshr_stream_mod.F90
+++ b/streams/dshr_stream_mod.F90
@@ -26,6 +26,7 @@ module dshr_stream_mod
   use shr_cal_mod      , only : shr_cal_advDate
   use shr_cal_mod      , only : shr_cal_advdateint
   use shr_cal_mod      , only : shr_cal_leapyear
+  use shr_sys_mod      , only : shr_sys_abort
   use dshr_methods_mod , only : chkerr
   use pio              , only : pio_noerr, pio_seterrorhandling, pio_inq_att, pio_openfile, pio_closefile
   use pio              , only : file_desc_t, pio_inq_varid, iosystem_desc_t, pio_file_is_open

to compile CDEPS when paired w/ the shr_log PR in CMEPS.

[jedwards4b]

Fixed, thank you @DeniseWorthen

[DeniseWorthen]

I got some strange failures for the subset of tests I ran. I'll look into it more tomorrow.

[billsacks]

Thank you very much for making these changes, @jedwards4b ! This mostly looks good to me. I have a few notes below about a few places where I think minor changes are needed, but other places look good to me.

[billsacks]

Looks good now - thank you!!