Skip to content

abort if any single column data is _Fillvalue#119

Merged
jedwards4b merged 1 commit into
ESCOMP:masterfrom
jedwards4b:fillvalue_chk_for_scol_data
Sep 1, 2021
Merged

abort if any single column data is _Fillvalue#119
jedwards4b merged 1 commit into
ESCOMP:masterfrom
jedwards4b:fillvalue_chk_for_scol_data

Conversation

@jedwards4b
Copy link
Copy Markdown
Contributor

@jedwards4b jedwards4b commented Aug 30, 2021

Description of changes

For single column cases (mapalgo == none) make sure that there is no missing data in the input stream, abort and report if any data is set to _Fillvalue.

Specific notes

Contributors other than yourself, if any:

CMEPS Issues Fixed (include github issue #): #115

Are there dependencies on other component PRs

  • CIME (list)
  • CMEPS (list)

Are changes expected to change answers?

  • bit for bit
  • different at roundoff level
  • more substantial

Any User Interface Changes (namelist or namelist defaults changes)?

  • Yes
  • No

Testing performed:

  • (required) aux_cdeps
    • machines and compilers: cheyenne intel
    • details (e.g. failed tests):
  • (optional) CESM prealpha test
    • machines and compilers
    • details (e.g. failed tests):

Hashes used for testing:

@jedwards4b jedwards4b requested a review from mvertens August 30, 2021 17:09
Copy link
Copy Markdown
Collaborator

@mvertens mvertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Thanks. Please enter your testing and more summary before you merge.

@jedwards4b jedwards4b merged commit 3ffc516 into ESCOMP:master Sep 1, 2021
@jedwards4b jedwards4b deleted the fillvalue_chk_for_scol_data branch September 1, 2021 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants