add support for REST_OPTION end and always write a restart at end of …#111
Merged
Conversation
…run unless restart is none or never
mvertens
requested changes
Aug 5, 2021
| type(ESMF_TimeInterval) :: timeStep | ||
| real(r8) :: nextsw_cday | ||
| logical :: restart_write ! restart alarm is ringing | ||
| logical :: rstwr ! restart alarm is ringing |
Collaborator
There was a problem hiding this comment.
Why change the name to a shorter name? What was wrong with restart_write?
Contributor
Author
There was a problem hiding this comment.
nothing, it was a cut and paste change. I've updated to restart_write.
|
|
||
| ! determine if will write restart | ||
| call ESMF_ClockGetAlarm(clock, alarmname='alarm_restart', alarm=alarm, rc=rc) | ||
| rstwr = dshr_check_restart_alarm(clock, rc=rc) |
Collaborator
There was a problem hiding this comment.
Great idea for code reuse! I'm sorry I did not think of this!
|
|
||
| end subroutine dshr_pio_init | ||
|
|
||
| logical function dshr_check_restart_alarm(clock, rc) |
Collaborator
There was a problem hiding this comment.
Could you please add a line or two of comments about our logic here. I think this would be helpful for future reference.
14 tasks
uturuncoglu
requested changes
Aug 6, 2021
uturuncoglu
approved these changes
Aug 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…run unless restart is none or never
Description of changes
Adds support for REST_OPTION=end and always writes restarts at end of run unless REST_OPTION is none or never.
Specific notes
Contributors other than yourself, if any:
CMEPS Issues Fixed (include github issue #):
Are there dependencies on other component PRs
Are changes expected to change answers?
Any User Interface Changes (namelist or namelist defaults changes)?
Testing performed:
Hashes used for testing: