Skip to content

NEON data inventory check#103

Merged
jedwards4b merged 7 commits into
ESCOMP:masterfrom
jedwards4b:neon_data_chk
Jul 13, 2021
Merged

NEON data inventory check#103
jedwards4b merged 7 commits into
ESCOMP:masterfrom
jedwards4b:neon_data_chk

Conversation

@jedwards4b
Copy link
Copy Markdown
Contributor

@jedwards4b jedwards4b commented Jun 25, 2021

Description of changes

Add support for downloading and checking the NEON data inventory file listing.csv
Generated new baselines due to FIELDLIST field lists differ jul12

Specific notes

Contributors other than yourself, if any:

CMEPS Issues Fixed (include github issue #):

Are there dependencies on other component PRs

  • CIME (list) hash 5f05541 on the trunk
  • CMEPS (list)

Are changes expected to change answers?

  • bit for bit
  • different at roundoff level
  • more substantial

Any User Interface Changes (namelist or namelist defaults changes)?

  • Yes
  • No

Testing performed:

  • (required) aux_cdeps
    • machines and compilers:
    • details (e.g. failed tests):
  • (optional) CESM prealpha test
    • machines and compilers
    • details (e.g. failed tests):

Hashes used for testing:

@jedwards4b jedwards4b requested review from ekluzek and mvertens June 25, 2021 14:53
@jedwards4b jedwards4b self-assigned this Jun 25, 2021
@jedwards4b jedwards4b changed the title working now NEON data inventory check Jun 25, 2021
@jedwards4b
Copy link
Copy Markdown
Contributor Author

In running the testlist_cdeps.xml one test fails: SMS_Vnuopc_Ld5_P1.1x1_mexicocityMEX.2000_DATM%1PT_SLND_SICE_SOCN_SROF_SGLC_SWAV_SESP.cheyenne_intel
with error:

(shr_stream_findBounds) ERROR: limit on and rDateIn lt rDatelvd
10101.0000000000 19931201.0833333

To fix this we can set the RUN_STARTDATE to 1993-12-02

@mvertens @ekluzek do you agree with this approach? It will mean creating a testmod directory in the cdeps repo and applying this change there.

@jedwards4b jedwards4b marked this pull request as ready for review July 12, 2021 16:39
@jedwards4b
Copy link
Copy Markdown
Contributor Author

@mvertens @ekluzek It turns out that this testmod was already avaialble in datm but was not specified in the test list. I have now added it and the test passes. This PR is ready for review.

Copy link
Copy Markdown
Collaborator

@ekluzek ekluzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I only have two suggestions.

First it should be an error if available_neon_data is on, and it's not a NEON stream.

Second, there two uses of the inputdata subdirectory cdeps/v1. That will likely be updated at some point, so it could be helpful to save it as a variable. I imagine it might exist other places as well.

I don't think either of these are required, but could be good to address.

@ekluzek ekluzek added the enhancement New feature or request label Jul 12, 2021
@ekluzek
Copy link
Copy Markdown
Collaborator

ekluzek commented Jul 12, 2021

The other thing that I'm pretty sure I know the answer to, but we should confirm. Outside of NEON this same capability won't come up for anything else right? This is safely a NEON-only type thing right? I'm pretty sure we think the answer to that is yes, but if it ever might crop up for something else you'd likely want a more generic name that doesn't have NEON in it.

@jedwards4b jedwards4b merged commit 663135a into ESCOMP:master Jul 13, 2021
@jedwards4b jedwards4b deleted the neon_data_chk branch July 13, 2021 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants