Skip to content

cam6_3_152: Fix for multiple monthly average history files.#1003

Merged
brian-eaton merged 3 commits into
ESCOMP:cam_developmentfrom
brian-eaton:mavg
Mar 21, 2024
Merged

cam6_3_152: Fix for multiple monthly average history files.#1003
brian-eaton merged 3 commits into
ESCOMP:cam_developmentfrom
brian-eaton:mavg

Conversation

@brian-eaton
Copy link
Copy Markdown
Collaborator

@brian-eaton brian-eaton commented Mar 20, 2024

resolves #1000

@brian-eaton brian-eaton self-assigned this Mar 20, 2024
@cacraigucar cacraigucar self-assigned this Mar 20, 2024
peverwhee
peverwhee approved these changes Mar 20, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@peverwhee peverwhee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for finding this, @brian-eaton !

I'll be interested to see if any regression tests aren't b4b (indicating that I missed an answer change). I'm confused as to why the other accumulated files were "working" (but perhaps they weren't...)

@brian-eaton
Copy link
Copy Markdown
Collaborator Author

brian-eaton commented Mar 21, 2024

thanks for finding this, @brian-eaton !

I'll be interested to see if any regression tests aren't b4b (indicating that I missed an answer change). I'm confused as to why the other accumulated files were "working" (but perhaps they weren't...)

The regression tests are b4b. We don't have any tests that include output to multiple monthly output files. The bug is in code that is specific to checking whether it's time to write history buffers to a monthly output file, i.e., nhtfrq==0. No other output frequencies were impacted.

@brian-eaton brian-eaton merged commit c97e39c into ESCOMP:cam_development Mar 21, 2024
@cacraigucar cacraigucar changed the title Fix for multiple monthly average history files. cam6_3_152: Fix for multiple monthly average history files. Mar 25, 2024
@cacraigucar cacraigucar mentioned this pull request Mar 28, 2024
Closed
gold2718 pushed a commit to gold2718/CAM that referenced this pull request May 2, 2024
@brian-eaton
ESCOMP tag: cam6_3_151
0f0599e 
Merge pull request ESCOMP#1003 from brian-eaton/mavg

Fix for multiple monthly average history files.

ESCOMP commit: c97e39c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cacraigucar cacraigucar cacraigucar approved these changes

@peverwhee peverwhee peverwhee approved these changes

Assignees

@brian-eaton brian-eaton

@cacraigucar cacraigucar

Labels

None yet

Projects

CAM Development
Status: Tag

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brian-eaton @cacraigucar @peverwhee