-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved linux/aarch64 build Python wheel build to native Github runners #2162
Conversation
Thank you so much for your help! Do you mean that we should use ubuntu 24 for all the workflows? Or just the python build ones? I see only one failing and I guess this should also be updated. Previously, I was trying to make sure we have tests on multiple ubuntu version runners, just to be on the safe side. If you've spotted some inconsistencies, it would be great if you could modify the runners as you feel is more sensible. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## latest #2162 +/- ##
==========================================
- Coverage 78.70% 78.69% -0.01%
==========================================
Files 345 345
Lines 83092 83129 +37
==========================================
+ Hits 65394 65422 +28
- Misses 17698 17707 +9 ☔ View full report in Codecov by Sentry. |
I attempted to harmonize the Python wheel builds in the workflows a bit more using |
Oh, and I missed your comment about multiple Ubuntu versions. If you prefer, we could extend the matrix to different combinations of Python and Ubuntu. Let me know if you have some in mind, I can add this as well. 😊 |
Thank you, @merschformann! This is great. I think I tested it once manually, and the wheels built on Ubuntu 24 still worked on older versions of Ubuntu, at least the Ubuntu 22 I tested on. Let's merge this as is, and if necessary, later on, we will add the previous versions. |
Description
This PR moves the linux/aarch64 build of the Python wheels to the recently released Github linux/aarch64 runners. This greatly simplifies and speeds up the Python wheel build, also, it addresses a current QEMU bug causing build errors.
Changes
ubuntu-24.04*
.cp311
(same as macOS.Notes/Questions
ubuntu-24.04-arm
, sinceubuntu-20.04
is not supported. I feel like the runners/builders should be aligned in their Ubuntu version. I didn't want to incur more change than necessary though. Should I align them?