Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved linux/aarch64 build Python wheel build to native Github runners #2162

Merged
merged 6 commits into from
Jan 30, 2025

Conversation

merschformann
Copy link
Contributor

@merschformann merschformann commented Jan 30, 2025

Description

This PR moves the linux/aarch64 build of the Python wheels to the recently released Github linux/aarch64 runners. This greatly simplifies and speeds up the Python wheel build, also, it addresses a current QEMU bug causing build errors.

Changes

  • Moves linux/aarch64 Python wheels build to native Github runners.
  • Harmonizes Python wheel for Linux to ubuntu-24.04*.
  • Harmonizes Python wheel tests to cp311 (same as macOS.

Notes/Questions

  • Addresses the issue at hand.
  • Is this all that is needed right now? Happy to extend the fix, if necessary.
  • This uses ubuntu-24.04-arm, since ubuntu-20.04 is not supported. I feel like the runners/builders should be aligned in their Ubuntu version. I didn't want to incur more change than necessary though. Should I align them?

@galabovaa
Copy link
Contributor

Thank you so much for your help! Do you mean that we should use ubuntu 24 for all the workflows? Or just the python build ones? I see only one failing and I guess this should also be updated. Previously, I was trying to make sure we have tests on multiple ubuntu version runners, just to be on the safe side.

If you've spotted some inconsistencies, it would be great if you could modify the runners as you feel is more sensible.

@jajhall jajhall changed the base branch from master to latest January 30, 2025 15:46
@jajhall jajhall requested a review from galabovaa January 30, 2025 15:46
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.69%. Comparing base (8591ad4) to head (fb910f0).
Report is 17 commits behind head on latest.

Additional details and impacted files
@@            Coverage Diff             @@
##           latest    #2162      +/-   ##
==========================================
- Coverage   78.70%   78.69%   -0.01%     
==========================================
  Files         345      345              
  Lines       83092    83129      +37     
==========================================
+ Hits        65394    65422      +28     
- Misses      17698    17707       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@merschformann
Copy link
Contributor Author

I attempted to harmonize the Python wheel builds in the workflows a bit more using ubuntu-24.04* and cp311. I hope this makes sense. Let me know, if something is missing / needs to be changed. ☺️

@merschformann
Copy link
Contributor Author

Oh, and I missed your comment about multiple Ubuntu versions. If you prefer, we could extend the matrix to different combinations of Python and Ubuntu. Let me know if you have some in mind, I can add this as well. 😊

@galabovaa
Copy link
Contributor

Thank you, @merschformann! This is great. I think I tested it once manually, and the wheels built on Ubuntu 24 still worked on older versions of Ubuntu, at least the Ubuntu 22 I tested on. Let's merge this as is, and if necessary, later on, we will add the previous versions.

@galabovaa galabovaa merged commit 4b7b234 into ERGO-Code:latest Jan 30, 2025
119 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants