refactor: support getDataBatch of 5.0.0 ERC725 release
#294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magalimorin18
approved these changes
Jul 7, 2023
|
lgtm |
CJ42
approved these changes
Jul 8, 2023
CallumGrindle
approved these changes
Jul 13, 2023
Hugoo
suggested changes
Jul 13, 2023
| // https://github.com/ERC725Alliance/ERC725/blob/v5.1.0/docs/ERC-725.md#erc725y | ||
| sig: '0xdedff9c6', | ||
| gas: numberToHex(2000000), | ||
| gasPrice: numberToHex(100000000), |
There was a problem hiding this comment.
I think we will need to make it dynamic at some point no? cc @CallumGrindle @magalimorin18
There was a problem hiding this comment.
whats this being used for? The lib doesn't send any transactions does it?
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## develop #294 +/- ##
===========================================
+ Coverage 83.04% 83.76% +0.71%
===========================================
Files 18 18
Lines 979 1084 +105
Branches 218 241 +23
===========================================
+ Hits 813 908 +95
- Misses 91 96 +5
- Partials 75 80 +5
|
Hugoo
reviewed
Jul 14, 2023
Hugoo
reviewed
Jul 14, 2023
Hugoo
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce (bug fix, feature, docs update, ...)?
Support
getDataBatchof 5.0.0 ERC725 release- Update ERC725Y interfaceId
- Update function selector for getDataBatch
- Reference the new version of ERC725Y as
ERC725Y_BATCHuntil we remove old version and rename to normalERC725YOther information: